Blender Git Commit Log

Git Commits -> Revision d647e73

Revision d647e73 by Ray molenkamp (master)
May 31, 2021, 15:59 (GMT)
Win: Fix warnings as errors being off for bmesh

bf_bmesh historically always build with the /WX flag
on windows making all warnings errors, somewhere along
the way this has broken for msbuild, ninja still exhibits
the expected behaviour.

The flags are still passed to the target, and I've validated
they are there when the add_library call fires, but they
somehow never make it to the generated msbuild project files.

I suspect this is a cmake bug but I'm seemingly unable
to extract a repro case to file a bug upstream.

Setting the same options target_compile_options seems to work,
I'm not happy about the unexplained nature of the breakage
but this will have to do for now.

Commit Details:

Full Hash: d647e730fbc23233b572594eeb6083978bdb882d
Parent Commit: b862916
Lines Changed: +4, -4

1 Modified Path:

/source/blender/bmesh/CMakeLists.txt (+4, -4) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021