Blender Git Commit Log

Git Commits -> Revision d822d47

Revision d822d47 by Sergey Sharybin (cycles-x)
July 23, 2021, 09:48 (GMT)
Fix OpenGL context usage in Cycles X

Activating nullptr context is not a valid way to release the active
context, there is a dedicated function for this.

This also showed a logical error in the buffer mapping: the buffer
unmap is not supposed to release current OpenGL context but should
instead leave it active for a possible subsequent calls to the GPU
update. It worked before because the context as never released due
to wrong API usage.

Would say that the WM OpenGL API should have an assert to catch
such case, but this better to happen in the master branch.

Noticed while doing a further development related to GPUDisplay and
watching return value of GHOST_ActivateOpenGLContext.

Differential Revision: https://developer.blender.org/D11989

Commit Details:

Full Hash: d822d4731fbb1575f39912823b59fa4b757a9a71
Parent Commit: 1265cf6
Lines Changed: +4, -26

1 Modified Path:

/intern/cycles/blender/blender_gpu_display.cpp (+4, -26) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021