Blender Git Commit Log

Git Commits -> Revision edb4e55

Revision edb4e55 by Bastien Montagne (master)
June 10, 2020, 07:38 (GMT)
LibOverride: Fix issues related to ID name differences.

Local datablocks (including overrides) need to have a unique name, which
can then differ from the reference linked one (especially when there are
several local overrides of a same linked data).

Issue is, ID name is a 'rna name property', and as such used as
reference when dealing with override of collections of IDs, so we cannot
have a changing name.

The solution implemented here should work and is simple, but it may have
some issues in corner cases (time will say), it is not really robust.

Alternative solution would be to store ID pointers as reference in
override operations, instead of there name. But that would potentially
add quiet a lot of overhead to foreach looping in `lib_query.c`.

Commit Details:

Full Hash: edb4e553f506c858e7df5e45ad6235cd59a181eb
Parent Commit: 2d1b560
Lines Changed: +23, -0

4 Modified Paths:

/source/blender/blenkernel/intern/lib_override.c (+6, -0) (Diff)
/source/blender/makesrna/intern/rna_access_compare_override.c (+4, -0) (Diff)
/source/blender/makesrna/intern/rna_ID.c (+1, -0) (Diff)
/source/blender/makesrna/RNA_types.h (+12, -0) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021