Blender Git Commit Log
Git Commits -> Revision f881ff1
Revision f881ff1 by Pablo Dobarro (master) April 14, 2020, 18:55 (GMT) |
Fix Shift-Smooth mode using wrong parameters When using the shift-smooth mode, sculpt_update_cache_invariants is changing the brush datablock of the paint session if it finds a brush named "Smooth" (which is a huge hack the brush management project should try to solve). This is done after the PaintStroke data in the modal operator is created, which holds a reference to the active brush in the paint session that was active when the operator started. Because of this, the StrokeCache was getting the correct smooth brush values but the paint modal operator was applying the wrong ones from the previous brush. This was causing the smooth brush behaves unpredictably depending on the current active brush. This patch updates the brush in PaintStroke on each modal callback, so it always gets the values from the current active brush in the Paint Session. The way brush switching works and a way to make it more flexible needs to be discussed in the future as part of the brush management project. The default smooth brush parameters and curves will probably need to be updated after this change, as previously they were set using an incorrect behavior. Reviewed By: jbakker Differential Revision: https://developer.blender.org/D7354 |
Commit Details:
Full Hash: f881ff129f785ed9491be04bc3dad6645903ddaa
Parent Commit: f12589d
Lines Changed: +1, -1
1 Modified Path:
/source/blender/editors/sculpt_paint/paint_stroke.c (+1, -1) (Diff)