Blender Git Commit Log

Git Commits -> Revision ff8288a

Revision ff8288a by Ray molenkamp (master)
May 3, 2020, 18:07 (GMT)
Windows: Replace BLI_File* calls with system calls in system_win32.c

Using BLI calls in this file triggered a condition where
poorly modelled dependencies in cmake (ie bf_blenlib using
zlib headers but not linking the libraries) leading to
linker error in debug builds of some of the tests.

This diff sidesteps the dependencies issue by using native
calls rather than BLI calls to check if a file exists and
what its size is. Effectively sweeping the issue right back
under the rug where I found it.

The best solution would be to audit all libraries and ensure
they have proper link requirements set, but that requires
significantly more time than I have available right now.
(zlib in blenlib was one of them and would have been easy
to fix, but there were others that required more work)

The alternative is tests that fail to build which worse.

I'll revisit this and fix it properly but for now this will
have to do.

Commit Details:

Full Hash: ff8288ad1e6997be6ada29543b6abdba18f47b24
Parent Commit: fe891d5
Lines Changed: +21, -18

1 Modified Path:

/source/blender/blenlib/intern/system_win32.c (+21, -18) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021