Blender Git Commits

Fix facemap drawing crash

Issue was that MPoly wasn't reset after iterating.

Fix old graph editor crash

Fix some potential bugs in facemap drawing code

Merge branch 'master' into wiggly-widgets

Remove unneeded widgetgroup customdata

Cleanup: Naming, consistent API call order

Add asserts to ensure functions are called in correct order

A bit silly having to ensure functions are called in correct order, but necessary for now.

Cleanup: Avoid special widget flag API functions, use general function instead

Minor corrections to previous commit

Doxygen documentation for widget library

And of course some minor cleanup.

Remove redundant arrow widget flag

Merge branch 'master' into wiggly-widgets

Get rid of overkill arrow widget custom line vec drawing

Instead, we now can use widget offset property to define starting point and a new arrow widget length property to define line length.

Merge branch 'master' into wiggly-widgets

Conflicts:
source/blender/editors/transform/transform_manipulator.c

Cleanup: Use BLI_INLINE

Remove redundant fixes

Not needed anymore since rB10678f7572ee0d37

Fix 3D view widgets not updated correctly

Was barely visible to users (noticed only with view oriented manipulator), since I fixed appearing issues individually. Will remove these fixes next.

Don't offset arrow widget range by property min value

Previously, the min value of the arrow range was set to be at the origin, but figured out in most cases this is actually not wanted (e.g: force field strength widget min value is -200, meaning at strength=0, the widget would be offset 200 pixels; camera focal length widget min value is 1, meaning widget was constantly offset by -1). Instead, the origin should be where the value of the property is 0.

This might still be wanted for some future cases, so leaving old behavior #ifdef'ed out.

Add initial camera focal length widget

Needs some more work still, especially, it should become a plane widget (currently it's just a new arrow style since it needs almost the same handling as an arrow).

Was requested in IRC, and seemed like a nice project to tackle until we found a way to fix facemap drawing :P

Update widgets attached to modal OP before handler might be freed

Some people were experiencing crashes with transform manipulator handling, this should fix it (although I'm not sure why it worked fine for me).