Blender Git Statistics -> Developers -> Baardaap

Martijn Versteegh (Baardaap)

Total Commits : 5
Master Commits : 5
Branch Commits : 0
First Commit : September 22, 2020
Latest Commit : November 26, 2021

Commits by Month

DateNumber of Commits
November, 20213
October, 20210
September, 20210
August, 20210
July, 20210
June, 20210
May, 20210
April, 20210
March, 20210
February, 20210
January, 20210
December, 20200
November, 20200
October, 20201
September, 20201

Favourite Files

FilenameTotal Edits
filter.c1
BKE_spline.hh1
spline_bezier.cc1
curve_eval.cc1
paint_image_proj.c1
readfile.c1
blender_sync.cpp1

File Changes

ActionTotalPer Commit
Modified71.4

Code Changes

ActionTotalPer Commit
Lines Added6613.2
Lines Removed224.4

Latest commits Feed

Revision 004172d by Martijn Versteegh / Sergey Sharybin (master)
November 26, 2021, 09:57 (GMT)
Clarify a confusing comment.

Affect and effect are too confusing for non-native english speakers
(like me). Also BAKING_MASK_MARGIN doesn't exist anymore in the code.

Reviewed By: sergey

Differential Revision: https://developer.blender.org/D13361
Revision 7aa39b4 by Martijn Versteegh / Hans Goudey (master)
November 11, 2021, 15:25 (GMT)
Fix: Prevent use of uninitialized memory when creating Bezier spline

When Constructing bezier splines from dna, the positions of the
left/right handles were set directly in the internal vectors, by
requesting a reference to them. The problem is that
BezierSpline::handle_positions_left() calls ensure_auto_handles()
before returning the reference. That function does some calculations on
uninitialized memory if the positions array is not yet filled.

Differential Revision: https://developer.blender.org/D13107
Revision 3df587b by Martijn Versteegh / Campbell Barton (master)
November 1, 2021, 11:16 (GMT)
Fix T92681: resolve use of freed filedescriptor in debug builds

Ref D13053
Revision f117966 by Martijn Versteegh / Brecht Van Lommel (master)
October 1, 2020, 12:37 (GMT)
Fix T80395: Cycles baking crash when Surfaces are disabled in the view layer

Always enable surfaces for baking, otherwise there is nothing to bake to.

Differential Revision: https://developer.blender.org/D9015
Revision c5efd09 by Martijn Versteegh / Bastien Montagne (master)
September 22, 2020, 08:30 (GMT)
Fix T80859: Thread safe pixeldata concersion from float to uchar and v.v.

I created a bugreport T80859 earlier.

The problem is in the file source/blender/editors/sculpt_paint/paint_image_proj.c (line numbers against commit d376aea61)

at the lines 5309 and 5320 the functions `IMB_rect_from_float(...)` and `IMB_float_from_rect(...)` are called from threaded code on a shared ibuf.
However, ps->reproject_ibuf is shared between threads, so this is not thread-safe.
This is a race condition and leads to wrong output when projecting float data onto a uchar texture or vice versa on a multithreaded system.
The checks on line 5308 and 5319 are already a race condition.

I created this patch which fixes the problem , but I'm not sure if I'm overlooking something.
This makes sure reproject_ibuf contains the correct formats *before* the threadpool is started.

I replaced the original location of the conversions with BLI_asserts(). That may be overkill?

Reviewed By: #sculpt_paint_texture, mont29

Maniphest Tasks: T80859

Differential Revision: https://developer.blender.org/D8936

MiikaHweb - Blender Git Statistics v1.06
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021