Blender Git Statistics -> Developers -> PhilChristensen

Phil Christensen (PhilChristensen)

Total Commits : 1
Master Commits : 1
Branch Commits : 0
First Commit : February 6, 2017
Latest Commit : February 6, 2017

Commits by Month

DateNumber of Commits
February, 20171

Favourite Files

FilenameTotal Edits
utfconv.h1
BLI_dynlib.h1
dynlib.c1

File Changes

ActionTotalPer Commit
Modified33.0

Code Changes

ActionTotalPer Commit
Lines Added44.0
Lines Removed44.0

Latest commits Feed

Revision 351c409 by Phil Christensen / Sergey Sharybin (master)
February 6, 2017, 09:44 (GMT)
C++ conformance fixes (MSVC /permissive-)

We (the Microsoft C++ team) use the Blender project as part of our "Real world code" tests.
I noticed a place in WIN32 specific code (dvpapi.cpp:85) where a string literal is losing
its const-ness when being passed to BLI_dynlib_open(). This is not permitted when using the
/permissive- conformance compiler switch (see our blog
https://blogs.msdn.microsoft.com/vcblog/2016/11/16/permissive-switch/)

My suggested fix is to add const and propagate it where needed. Another possible fix would be
to explicitly cast away the const.

Reviewers: mont29, sergey, LazyDodo

Subscribers: Blendify, sergey, mont29, LazyDodo

Tags: #platform:_windows

Differential Revision: https://developer.blender.org/D2495

MiikaHweb - Blender Git Statistics v1.06
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021