Blender Git Loki

Cleanup: enabled Clang-Tidy `bugprone-not-null-terminated-result` rule

No functional changes because no code changed.

Cleanup: fixed Clang-Tidy `bugprone-suspicious-string-compare` warnings

No functional changes.

Merge branch 'blender-v2.90-release'

Fix previous commit, we first need to be sure we actually get a mesh...

Merge branch 'blender-v2.90-release'

Fix T79604: Switching to edit mode on boolean object runs out of memory.

Note that this is a dummy safe fix for now, far from optimal.

Cleanup: CMake warnings related to "find package" modules

Fix package name missmatch in a few module files. IE "ALEMBIC" was
defined in the file but the find_package commands used "Alembic"

Some modules state that they set and use the _LIBRARY variable but the
do in fact not do this. Removed these comments from those files.

Cleanup: enabled Clang-Tidy rule `bugprone-infinite-loop`

Enabling it and doing a full rebuild didn't cause any warnings, so nothing
else to do here.

No functional changes.

Cleanup: added explanation of why `incircleadapt` is allowed to be long

This is a followup of d4bd0789abb6e7805e07636232cec4480028f6d1, as it was
lacking a bit of an explanation.

No functional changes.

Cleanup: enable and silence Clang-Tidy readability-function-size

Enable Clang-Tidy's `readability-function-size` rule and add a few
`NOLINT` markers to explicitly silence warnings for three functions.
These functions are huge and would IMO benefit from splitting up, but
are hard to without intimate knowledge of the code.

At least by enabling the rule, we can start tweaking the values and
refactoring other functions that bubble up as being too long/complex.

No functional changes.

Cleanup: Nodes, silence Clang-Tidy readability-function-size

Add a `NOLINT` marker to explicitly silence a warning from Clang-Tidy's
`readability-function-size` rule for the `node_type_base()` function.
This function is indeed huge, but that is because a lot of macros are
expanded. Before expansion things are still not small, but still
understandable & expandable.

No functional changes.

Fix crash due to OBJ files with no `o name` line

In some exporters, the group serves as the object name.

Also add some asserts.

Rename `list_of_objects` to `all_geometries`.

Cleanup: Clang-Tidy. readability-non-const-parameter in pixel drawing

Fix T79571: "Assign Shortcut" doesn't work for "Clear Keyframes"

In the 3D View, the "Animation" keymap is not used, but the mode
specific ones. So the shortcut editing code should use these too, just
like the default keymap does.

Cleanup: Delaunay 2D, silence Clang-Tidy readability-function-size

This adds a `NOLINT` marker to explicitly silence a warning from
Clang-Tidy's `readability-function-size` rule for the `incircleadapt()`
function in `delaunay_2d.c`.

No functional changes.

Cleanup: Versioning: silence Clang-Tidy readability-function-size

This adds `NOLINT` markers to explicitly silence warnings from Clang-Tidy's
`readability-function-size` rule for versioning functions. Technically
these could be refactored and split up into smaller bits, but generally
they are hardly ever looked at once they're a few releases old.

No functional changes.

Cleanup: PyBGL, Clang-Tidy readability-function-size fixes

This addresses warnings from Clang-Tidy's `readability-function-size`
rule in the `source/blender/python` module.

It's just `BPyInit_bgl()` that's been split up into one or two smaller
functions per OpenGL version.

No functional changes.

Merge branch 'blender-v2.90-release'

Fix T79201: Mantaflow: Fluid guides don't affect simulation.

This broke during the OpenVDB update for 2.90. Just making sure that guiding velocity files are being read correctly.

Add debugging to face merge.