Blender Git Loki

Cleanup: unused headers in editors

Revert "Modifiers: every modifier now copies mesh settings, fixing texture space issues"

This reverts commit e7a514369fe700dcc5a1fe433c8f709ed9595ded, it introduces
a bug in selection in edit mode.

Fixes T70103: can't select extruded Vertex

Ref T64739

Fix build error in debug build on macOS

NDEBUG is the standard define, not DEBUG.

UI: Avoid file browser directory change if path didn't change

E.g. entering the file path field and then pressing enter without any
change would call an unneccesary directory change, causing flickering.
So the main point of this is to avoid flickering.

Without this the text field could also be used to refresh the file list,
but for that we have a proper button.

UI: Replace big options button in file browser

The big options button in the lower left is now gone, it's replaced by a
smaller icon toggle button in the upper right.
That means I could also remove code for the region we had just for this
button.
I also added versioning code for the removal, to make sure the region is
removed cleanly when reading old files.

Fix T70109: Crash with the Data Transfer Modifier (with any 'Edge Data' option)

The BVHTree was erroneously marked as not cached.

UI: Use vertical file list for "Recover Auto Save"

Pablo and William agreed that the main purpose of the layout should be
to list files in a way that it's easy see which files were
created/modified when. Previously it was set to "Long List" to show the
modification time, now the vertical list is much better suited. The time
is shown anyway.

Fix T70112: Spot cone prevents selection

Remove redundant file bookmarks region toggle operator

For the default keymap we were only using the regular toolshelf
operator, doing this for the industry compatible keymap too now (we
could even remove it there, we don't use it in other editors).

Since we "now" have proper operators for toggling regions, this specific
one is totally redundant.

Refactor: Ensure there's always a valid file editor tool region

So far the file browser code had some lazy creation for the tool region,
even though it should always be there. The only reason I can see for
this is compatiblity. So I simply added versioning code to add the
region in case it's not there. Now we should be able to savely assume
the tool region to be there, whithout any unusual lazy-creation.

Rewrite file region handling for non-editor mode

This makes it so that regions only needed when the file browser is
invoked as an operation (e.g. Ctrl+O rather than a regular editor) are
lazy created then, and removed if the file browser is changed into a
regular editor then (e.g. Ctrl+O over regular file browser editor ->
Cancel).

That should remove some troublesome assumptions and makes versioning
redundant.
It also fixes the issue of an empty execute region at the bottom after
cancelling a file operation invoked from a regular file browser editor.

UI: Fix Capitalization

Differential Revision: https://developer.blender.org/D5716

UI: Incorrect info message after batch rename

Differential Revision: https://developer.blender.org/D5744

Fix T69097: Empty context menu for dimensions

Adjust empty menu check to skip the menu title.

Cleanup: discarded-qualifier warning

Fix T69486: Reloading file in text editor marks file as modified

Differential Revision: https://developer.blender.org/D5847

Cleanup: Add/use utility to remove regions

Fix empty file options region in regular editor

This would happen when opening a file browser as regular editor, opening
a temporary file browser from there (e.g. Ctrl+O) and cancelling the
operation.
In some cases this would cause most of the editor to be filled with an
empty operator options region:
* Go to Shading workspace
* File -> Append
* Cancel

Fix paint cursor drawing asserts

The new paint cursor (introduced in rBe0c792135adf) mixed 3d and 2d
drawing leading to asserts [e.g. when tablet pressure sensitivity was
enabled for size, see D5820 also].

We could get away with always drawing in 3D [using vertformat with
comp_len 3 / GPU_SHADER_3D_UNIFORM_COLOR / imm_draw_circle_wire_3d],
even if in the Image Editor, but this patch clearly separates what is
drawn in 3d and what is in 2d.

part of T69957

Reviewers: jbakker

Differential Revision: https://developer.blender.org/D5836

Fix T69995: Object Drawtype Set To Solid Issues

When setting an object draw type to Solid it always used the Material
color mode. This change only sets the material color when the viewport
is set to display textures.