December 9, 2021, 17:01 (GMT) |
Fix T93890: Cycles error with shadow catcher + OptiX denoise without passes |
December 9, 2021, 16:46 (GMT) |
Fix T93874: Cycles crash with fast GI approximation |
December 9, 2021, 16:36 (GMT) |
Fix T93871: Image.has_data returns True for images that failed to load |
December 9, 2021, 15:47 (GMT) |
Fix T93892: Changing bone name leaves non-functional vertex group The corresponding vertex group was renamed properly, but the armature influence was broken for that bone. Caused by {rB3b6ee8cee708}. Since above commit, vertex group names are stored on object data (mesh/ lattice/gpencil) and if we update these, we have to inform dependency graph to have immediate effect. Maniphest Tasks: T93892 Differential Revision: https://developer.blender.org/D13526 |
December 9, 2021, 14:51 (GMT) |
Fix T93691: Crash when loading custom thumbnail in custom library This was an issue with the mixed list of external assets and assets from the current file. When closing the File Browser to select the custom preview image, the assets from the current file would be cleared for reread, to make sure we display up-to-date file data. That is because the workspace of the temporary File Browser was deleted, causing a change in the file data (main data-base). The reread would happen in a background thread, meaning it might not finish before the custom preview operator runs and queries the active asset. So the preview operator would get the wrong active asset from context. Two fixes were needed: * Make sure current file data is reread before the operator runs, by doing this partial rereading on the main thread. * Ensure the asset list (in fact file list) order stays consistent over rereads. If multiple assets with the same name were shown, the operator might also have gotten the wrong asset, also leading to a crash. Additionally the file operation handler should probably poll before executing, to fail gracefully at least (not crash). |
December 9, 2021, 12:54 (GMT) |
Fix (unreported): missing null check A crash happened when `instance_id_attribute` further down in the function was null. This issue was probably introduced when the id attribute starting using generic attribute handling. |
December 9, 2021, 11:47 (GMT) |
December 9, 2021, 11:37 (GMT) |
December 9, 2021, 11:35 (GMT) |
Cleanup/Documentation: Add/move comments for asset files Adds some basic high-level explanations for editor/UI level asset APIs. Also moves one such comment from the source file to the header file, so it's in the same file as other API comments. |
December 9, 2021, 11:35 (GMT) |
Cleanup: Various cleanups to the tree-view API * Correct URL for documentation (was changed recently). * Add comments. * Reevaluate and update which functions are public, protected or private. * Reorder functions and classes to be more logical and readable. * Add helper class for the public item API so individual functions it uses can be made protected/private (the helper class is a friend). Also allows splitting API implementation from the C-API. * Move internal layout builder helper class to the source file, out of the header. * More consistent naming. * Add alias for item-container, so it's more clear how it can be used. * Use const. * Remove unnecessary forward declaration. |
December 9, 2021, 11:25 (GMT) |
December 9, 2021, 10:19 (GMT) |
Cleanup: use doxy section for itasc_plugin It wasn't obvious all callbacks were part of the plugin-API. |
December 9, 2021, 10:17 (GMT) |
December 9, 2021, 10:15 (GMT) |
Fix T93519: handle prefix names in autocompletes Autocomplete entires keep track of the length of the prefix in `name_prefix_offset`. However, the name matching logic was comparing the string including the prefix which resulted in tab-completion not working (when the user didn't also type in the prefix, typically two whitespaces). This is fixed by passing in a char pointer after the end of the prefix. Additionally, some searchbox logic is moved. Previously, `ui_searchbox_apply` would clear the entry which would mean that `ui_searchbox_find_index` would never succeed. Now the search box is only cleared if no match was found. Differential Revision: https://developer.blender.org/D13483 |
December 9, 2021, 10:09 (GMT) |
December 9, 2021, 09:58 (GMT) |
December 9, 2021, 09:34 (GMT) |
December 9, 2021, 09:23 (GMT) |
December 9, 2021, 09:21 (GMT) |
Cleanup: spelling in comments |
December 9, 2021, 09:11 (GMT) |
Cleanup: move public doc-strings into headers for 'gpencil_modifiers' Removed doc-strings for operator definitions as they didn't provide useful information in addition to the operators own description. Ref T92709 |
|