Blender Git Loki

Cleanup: Make function static, use const object argument

Also use `const Curve *` instead of `const Object *`, since the
function works at a lower level than objects anyway.

And also remove another unused function. Since this section of code
for converting curves to meshes will likely be replaced, it's nicer to
see which parts actually remain used at this point.

Cleanup: use '#if 0' for disabling multiple lines

Cleanup: reserve C++ comments for disabled code

Use C comments for plain text.

LineArt: UI cleanups.

Wording on the UI, slider consistency and material mask switches layout.

Reviewed By: Sebastian Parborg (zeddb)

Differential Revision: https://developer.blender.org/D11839

Compositor: Fix crash when connecting multiple constant inputs

Operation receiving inputs was being folded more than once
when it was constant foldable.

Fix crash in delaunay C interface test.

The test forgot to set the new need_ids field, which luckily
exposed a bug in the C api for delaunay when that field is false.
Fixed the bug and the test, and added a test for the need_ids false
case.

Cleanup: Remove redundant forward declarations.

Cleanup: added const keyword to BLI_dlrbTree search functions.

Cleanup: use doxygen style parameters in noise.c

These used their own ad-hoc syntax.

Cleanup: use single back-tick quoting in comments

While doxygen supports both, conform to our style guide.

Note that single back-tick's are already used in a majority of comments.

Fix T89979: Assert in edit mode with curve to mesh node

The node tagged polys normals dirty, but the function to calculate the
normals didn't clear the dirty flags for polys. Now clear the poly and
corner dirty normal flags.

Fix: Bezier segment node adds handles incorrectly

This caused the "cyclic" attribute to appear dysfunctional.

Fix T89982: Geometry Nodes: 'New' Button tries to create node_tree on active modifier, rather than button context

When done from the Properties Editor, the context's modifier should be
used (this is where the button is located), when done from elsewhere,
the active modifier is still the way to go (since the context modifier is
not available then)

Maniphest Tasks: T89982

Differential Revision: https://developer.blender.org/D11972

Fix T89981: missing refresh on the compositors render layer node when adding/removing AOVs

Just refresh the node's outputs via ntreeCompositUpdateRLayers().

Maniphest Tasks: T89981

Differential Revision: https://developer.blender.org/D11973

Pose backup: convert from C to C++

Convert `pose_backup.c` (in C) to `pose_backup.cc` (in C++). This will
make future improvements easier. For now, it's the same code with just
some additional explicit casts (C++ doesn't allow implicitly casting
`void *`), `NULL` changed into `nullptr`, and some other simple changes.

No functional changes.

Cleanup: fix clang-tidy warning modernize-use-nullptr

No functional changes.

Cleanup: fix clang-tidy readability-else-after-return

No functional changes

Cleanup: fix clang-tidy warning readability-qualified-auto

No functional changes.

Pose Library: remove assumption about Action group names

Remove the assumption of the pose library that Action groups are named
after the bones in the armature. Even though this assumption is correct
when the keys are created by Blender, action groups can be renamed. Keys
created by Python scripts can also use arbitrary group names.

Since there is more code in Blender making this assumption, and looping
over selected bones is also a common occurrence, this commit contains
some generic functionality to aid in this:

- `BKE_armature_find_selected_bones`: function that iterates over all
bones in an armature and calls a callback for each selected one. It
returns a struct with info about the selection states (all or no bones
selected).
- `BKE_armature_find_selected_bone_names(armature)` uses the above
function to return a set of selected bone names.
- `BKE_pose_find_fcurves_with_bones()` calls a callback for each FCurve
in an Action that targets a bone, also passing it the bone name.

Cleanup: Fix missing braces warning on Clang