Blender Git Loki

Cleanup: Rename curve node enums

The enum called "interpolate" was really a choice of methods for mapping
inputs to positions on the curve, whereas the "sample" enum was used to
define a way to create a whole set of new points from the curve, without
any input parameters. The "re-sample" vs. "sample" naming makes that
distinction better.

Compositor: Fix Alpha Over node ignoring emissive colors

It was an issue on Full Frame mode only.

Compositor: Fix crash exporting buffers on debug

ImBuf allocates 4 channels, use copying to support buffers
with 1 and 3 channels.

Compositor: Add OIDN prefiltering option to Denoise node

It's equivalent to the OpenImageDenoise prefiltering option in Cycles.
See D12043.

Prefilter modes:
- None: No prefiltering, use when guiding passes are noise-free.
- Fast: Denoise image and guiding passes together. Improves quality when
guiding passes are noisy using least amount of extra processing time.
- Accurate: Prefilter noisy guiding passes before denoising image.
Improves quality when guiding passes are noisy using extra
processing time.

Reviewed By: #compositing, jbakker, sergey

Differential Revision: https://developer.blender.org/D12342

Cleanup: Fix/improve variable names and comments

Fix build error after previous commit

Incorrect renaming and use of enum after search and replace.

Fix: Spline length calculation fails with no evaluated points

The case that checked whether there were evaluated edges was incorrect,
since two points are needed for an edge. Then also avoid running the
accumulation for an empty span.

Fix: Incorrect default values for the curve trim node

The default end factor should be 1. The proper value for the default end
length is somewhat arbitrary, but it shouldn't be zero.

Fix: use type name instead of variable name

That was a typo in rBfd60f6713a9d9e6f7d706b53bf1311f2f1cd9031.

Cleanup: simplify resource scope methods

Previously, a debug name had to be passed to all methods
that added a resource to the `ResourceScope`. The idea was
that this would make it easier to find certain bugs. In reality
I never found this to be useful, and it was mostly annoying.
The thing is, something that is in a resource scope never leaks
(unless the resource scope is not destructed of course).

Removing the name parameter makes the structure easier to use.

Nodes: cache node declaration on node

Previously, it was necessary to rebuild the node declaration
every time it was used. Now it is cached per node for easy
and fast access.

For more details on what this is, look at the comment in
`DNA_node_types.h`.

Differential Revision: https://developer.blender.org/D12471

Cleanup: fix inconsistent parameter name

Found by clang-tidy.

ID management: Add new version of `relink_to_newid` using proper new remapping code.

Current `BKE_libblock_relink_to_newid` is using its own simplistic,
limited and not really correct version of ID remapping.

While doing a full replacement would have been ideal, this is
risky/time-constrained for Blender 3.0 release, so for now we'll have
both versions co-existing.

LibLink: New Append code.

This commit fully refactors the way linked IDs are made local when
appended.

Previously, `BKE_library_make_local` was (ab)used for this task, but it
was missing some contextual data and doing complex processing to try to
work around this, with limited sucess. Further more, it was nearly
impossibe to extend (e.g. to get new append behaviors necessary for the
asset project).

The new code is a dedicated append step in WM linking process.

NOTE: BPY API (`libray.load()` context manager) uses its own code here,
which still relies on `BKE_library_make_local` for appending.
Unfortunately, merging those two different code paths is not trivial so
for now this API will remain unchanged.

Fix T55629: Append already linked Data is impossible.

LibLink: Enable unittest that was previously failing in append case.

Previous commit fixed it.

Fix T89027: "factor" field in pose breakdowner not updated

After applying the pose breakdowner,
the "factor" slider in the redo panel wasn't set to the correct value
This would cause the pose to jump around
once you start dragging the slider

Reviewed by: Sybren A. St�vel
Differential Revision: https://developer.blender.org/D12187
Ref: D12187

Fix: Use after free in spreadsheet attribute column ID

A temporary string was created in the attribute_foreach callback
and used in a map at a higher scope. When the callback finished,
the string went out of scope, was freed, then the elements in the
set pointed to freed memory.

Cleanup: doxy sections, parameter syntax

Cleanup: spelling

Fix T89241: Scale to fit overflows into a second line