Blender Git Loki

Cleanup: Fix Clang braced-scalar-init warning

Fix T89450: Crash slicing BMEditSelSeq

Slicing with indices greater than the length of the sequence would crash.

XR: Action Binding Improvements

Provides several important improvements to the runtime action
bindings operation and internal API.

Moves input-specific action data (input thresholds, input regions,
pose offsets/spaces) from actions to more granular action bindings.
This allows a single action to be mapped to a variety of inputs,
without having to share a single input threshold, region, or space.

Also removes the need for action space creation API, as spaces for
pose actions will be automatically created with the bindings.

The correct action data for the current inputs is set by calling
xrGetCurrentInteractionProfile() to get the current profile and then
retrieving the corresponding mapped data.

Does not bring about any changes for users since only internal
runtime functionality is currently affected.

Reviewed By: Julian Eisel

Differential Revision: https://developer.blender.org/D12077

Fix slicing with negative indices

Negative indices that remained negative after adding the sequence length
caused incorrect slicing.

With the default scene for example:

bpy.context.scene.objects[-4:2]

Gave a different result to:

tuple(bpy.context.scene.objects)[-4:2]

Clamp indices above zero so loops that step forward works as intended.

Cleanup: remove redundant parenthesis

Fix T90256: faces are flat shaded in edit mode with auto smooth

Regression in 39b2a7bb7e815e051348bf5c5ec777d091324164.

Fix T89835: Crash after Instancing to Scene after making linked Collection local.

Even though the ID itself remain the same after being made local, from
depsgraph point of view this is a different ID. Hence we need to tag all
of its users for COW update, as well as rebuild depsgraph relationships.

Should be also backported to LTS 2.93 (and 2.83 if possible).

Fix T90170: `RNA_property_pointer_get` creating data in non-thread-safe way.

Protect this accessor with a local static mutex when it needs to
create/write data.

Ideally accessors should never create or modify data, but there are some
cases where this bad behavior is currently unavoidable.

This is the case of the Pointer accessor when the actual IDProperty has
not yet been created.

NOTE: this fixes a memory leak in liboverride diffing process when
several different overrides use a same linked reference ID.

Differential Revision: https://developer.blender.org/D12060

Fix T90430: Crash when dragging material

Was trying to get asset information even when there was none, i.e. when
the material wasn't an asset or not dragged from the Asset Browser.

Fix T89214: Smooth Vertices (Laplacian) produces NaN coordinates

Vertices with no connected faces would attempt to divide by the combined
face area causing a divide by zero.

Use the same weight for wire vertices as vertices connected
to zero area faces.

Cleanup: Remove unused members in FileSelectParams

Fix fix invalid index use for edit-mesh laplacian smooth

Only vertex indices were ensured to be correct.

Fix T89963: crash when library override is applied to an object from a linked scene.

LibOverride of scenes is not really supported currently, there are many
issues with it.

Will disable most user-accessible ways to create such overrides in a
following commit.

LibOverride: Make it reasonably impossible for users to create overrides of scenes.

This is not supported currently,doing so through RNA API remains
possible, but from regular UI operations it should not be doable
anymore.

Ref. T90459.

XR: Controller Data Improvements

Provides two key improvements to runtime controller data.

1. Separates controller poses into two components, "grip" and "aim",
which are both required to accurately represent the controllers
without manual offsets.

Following their OpenXR definitions, the grip pose represents the
user's hand when holding the controller, and the aim pose represents
the controller's aiming source.

2. Runtime controller data is now stored as a dynamic array instead
of a fixed array. This makes the API/functionality more adaptable to
different systems.

Does not bring about any changes for users since only internal
runtime functionality is currently affected.

Reviewed By: Julian Eisel

Differential Revision: https://developer.blender.org/D12073

Fix select engine buffer having wrong vertex size

The theme used was wrong and the vertex size is twice as set in the theme.

Fix broken logic in Windows directory query function

Mistake in a5bbdd6998ab

macOS: Fix OpenMP dynamic loader error.

Fix calculation of 'projmat_dimensions'

`r_left`, `r_right`, `r_bottom` and `r_top` were ignoring `clip_near` value
when in perspective view.

Also rename `projmat` to `winmat` in these cases.

Cleanup: spelling