Blender Git Loki

Cleanup/update comment on flag_legacy values

Fix T63343: Duplicated object is hidden whereas it should not

We were mixing ob->flag and ob->base_flag.
We shouldn't be using ob->flag & SELECT in 2.8x.

Stop using deprecated ob->flag & SELECT

We still have base->flag_legacy & BA_WAS_SEL for the few cases we really
need to have a per-object selection check (used in the transform code).

Remove BKE_scene_object_base_flag_sync_from_object

Note the fix for T62865 is still working fine.

Refactor: Use object select API - ED_object_base_select

We had a mix of BKE_view_layer_base_select (harmless), and places where
we simply set the BASE_SELECTED flag with no regard to its selectable
state.

Grease Pencil: Fix using wrong flag for selecting objects on convert

The correct fix should be to use ED_object_base_select() but I'm leaving
this to a separate pass.

Cleanup: Object base syncing already happening as part of ED_object_base_select

No functional change.

Industry Compat Keymap: Fix Knife tool

Was adding new cuts automatically.

GPencil: Small tweak to Dot minimum thickness

This was changed in a previous commit to 1.0, but a value of 0.5 works better.

Fix T63864 Duplicate Data options don't exist for Light Probe and Grease Pencil

See revision D4766

Select: Add 'deselect on nothing' to NLA editor.

Should be last part of T63995.

Tweak to previous 'deselect on nothing' commit for Graph editor.

Better code, more in line with the one from action and NLA, and less
verbose.

Fix (unreported) two memleaks in clic-select ops of Action and NLA editors.

Select: Add 'deselect on nothing' to Action (dopesheet) editor.

Also removed annoying console error when clicking outside of valid range
of channels, that is no error at all. ;)

Part of T63995.

Select: Add 'deselect on nothing' to Graph (fcurves) editor.

Part of T63995.

Select: Add 'deselect on nothing' to UV editor.

As with mask, when this is enabled there is now a maximum click distance
from an item to actually select it.

Part of T63995.

Fix proportional editing always enabled if the property exists in the
operator

Fixes T64010, T64011

Reviewers: brecht

Maniphest Tasks: T64010, T64011

Differential Revision: https://developer.blender.org/D4764

Refactor markers drawing

This will make it easier to move the markers area somewhere
else (to the top) in a separate step.

There should be no functional changes, only minor UI changes.

Reviewers: brecht

Differential Revision: https://developer.blender.org/D4745

Refactor: Separate scrollers from text drawing in API

This is a continuation of rB7fdffd735ff24, where I separated the
e.g. frame number drawing from scrollers internally.
This patch changes the API, so that space draw handlers
have to draw these numbers explicitely.

This greatly simplifies the scrollers API for all spaces
that just need scrollers without any frame numbers.

Reviewers: campbellbarton

Differential Revision: https://developer.blender.org/D4747

Fix T63393 Eevee: Specular Shader's Clear Coat does not function