Blender Git Loki

Fix T84516: ID properties have incorrect names in Python dir() list

Caused by not going through the proper accessor function to access the
property identifier.

Cleanup: remove trailing whitespace

Geometry Nodes: transform Object Info outputs to local space

Ref T83670.

Differential Revision: https://developer.blender.org/D10071

BLI: fix math operation

That fixes a stupid mistake of mine that was copied a couple of times.

Cleanup: remove redundant UV edge selection calls

Selecting vertices and faces first checked edge selection,
this was called to set vert1 & vert2 variables which have since been
removed.

These calls should have been removed in
51f04bf7b8ee03a7973c50e525ffa5c67dde5fb7.

Fix T84565: UV face select fails when zoomed in

Exposed by recent commit 246efd7286f6187e4dd4b3edcc79cccb1746bb1d

Although this was an existing logical error causing
`uv_find_nearest_face` to only work properly when the hit distance was
initialized to FLT_MAX, which wasn't the case in multi-object edit mode.

Fluid: Adjusted viscosity strength step size in UI

Step size was too small.

Fix T84327: outliner_id_copy_tag was only copying from expanded nodes.

If a node was closed in the hierarchy, we would only copy that node,
even if child nodes were selected.

Reviewed By: brecht, mont29

Maniphest Tasks: T84327

Differential Revision: https://developer.blender.org/D9995

Cleanup: Added const to RenderLayersProg methods

VSE: store raw images in cache

Previously raw images were not cached if image wasn't preprocessed.
This caused issue, that image had to be read from disk on every redraw.

Effect strips must be excluded, because this would cause problem with
invalidation. Effect strips can use preprocessing however. This is
mainly to allow usimg modifiers on them.

This change should follow rBf448ff2afe7a77, but I have wrongly assumed,
that it has been implemented already.

ref T80278

Tests: run suites instead of individual test cases

Group all tests of a test suite into a single test command invocation.
This reduces the number of invocations by `ctest` by an order of
magnitude.

Since rB56aa5b0d8c6b663, `bin/tests/blender_test` was run for every
individual test. Having over a 1000 tests made testing slower than
necessary. Individual tests can still be run if desired by invocation of
`bin/tests/blender_test --gtest_filter=suitename.testname`.

NOTE: For this commit to have an immediate effect, it may be necessary
to remove the `tests` and `Testing` directories and some CMake files
from your build directory and rebuild. Run `ctest -N` to see the list of
tests; there should be less than 200.

Reviewed By: sergey, LazyDodo, sebbas

Maniphest Tasks: T83222

Differential Revision: https://developer.blender.org/D9649

Fix versioning code outside of version check

Bug introduced in f448ff2afe7a probably due to mistake when resolving
conflicts and not checking functionality.

Fix T83544: Cycles crash when rendering with Save Buffers enabled

The issue is that the "Noisy Image" pass is added even though it should not.

`use_denoising` has to be enabled on the scene and on the view layer
to actually enable it.

Differential Revision: https://developer.blender.org/D10048

Reviewers: lukasstockner97, brecht

Fix T84459: Wireframe not displaying with AMD GPU

Issue appears to be caused by AMD graphics driver later than 20.11.1 and
affects older GPUs (Polaris/FIJI cards). Wireframe drawing uses the same
OpenGL data type for storing normals what is known to be faulty.

This patch enabled storing the normals using GPU_COMP_I16. It also
solves the normals drawing in edit mode for vertex and loop normals.

Cleanup: Incorrect comment

Fix T84459: Face normals not displaying (AMD GPU)

This is part two of the fix for T84459.
Issue appears to be caused by AMD graphics driver later than 20.11.1 and
affects older GPUs (Polaris/FIJI cards). Drawing normals in edit mode
uses the same OpenGL data type for storing normals that is known to be
faulty.

This change fixes the face dot normals by using GPU_COMP_I16.

Cleanup: skip accessing sequence strip name/source when hidden

Fix incorrect use of BLI_snprintf in sequencer text concatenation

The start of the text was stepped over without subtracting it's length
(introduced in fad80a95fd08ec87a37f30f0b94a7061d4e382f2).

Replace this logic with BLI_string_join_array to simplify construction.

Fix missing directory separator in image/movie strip identifier

Cleanup: use switch statement for sequence types

Also remove duplicate NULL pointer check and replace
BLI_snprintf with BLI_strncpy.