Blender Git Loki

Cleanup: Remove weird assert in button handling

The function this was in already checks the conditions under which it
can operate (as it should). No need to force the caller to do these
(quite specific) checks, the function can just do nothing if the button
doesn't need these operations.
Otherwise we'd have to always execute these checks before calling, which
makes calling it a hassle, makes the code harder to follow and generally
harder to maintain (what if the conditions change?).

Fix assert failure when using Ctrl+Mousewheel on Object Mode button

Do a proper check to see if the button supports Ctrl+Mousewheel cycling.

See T80659.

Fix datatoc_icon linker errors with ASan enabled.

Error introduced in {rBf9fcb25d521d}.

Reviewed By: brecht

Differential Revision: https://developer.blender.org/D8964

Make deps: Enable fPIC for Linux

Similar to D8823.

Implement ID properties support for TimeMarker

Allows scripters to store additional information in the marker itself instead
of using work-around approach based on marker names and such.

Differential Revision: https://developer.blender.org/D8944

Fix T79965: mesh.transform() modifies referenced layers

Originally was noticed when transforming mesh created by
object.to_mesh() from an object without modifier, in which case the
result references CustomData layers used by the object itself.

The issue goes a bit deeper: mesh.transform() should never modify
referenced layers, hence it should duplicate referenced layers.

This fix changes one specific aspect of the reported behavior. The
case where vertices coordinates are modified manually will still have
affect on the source mesh (as no referenced CustomData layers are being
duplicated). Proper fix for this case is not yet clear to me.

Differential Revision: https://developer.blender.org/D8939

Fix T80931: Proporional Editing Cursor Draws Incorrect

The incorrect view was setup so it was drawn in pixel space. This patch
changes it to use UV space.

Fix T79373: Forbid painting on linked image.

There is just no reason to support that kind of useless behavior.

Some remote TODO could be to define a process based on liboverride and
layers.

Fix T59272: dead particles not included in render, but visible in viewport

The issue was that the pointcache was not storing dead particles,
even though they are displayed. This lead to the rendering issue,
because only alive particles can be read from the point cache in
the frame that is rendered.

This also fixes an issue unrelated to rendering: when dead particles
are displayed, their position is incorrect when some frames are
skipped during playback.

Reviewers: brecht

Differential Revision: https://developer.blender.org/D8907

Cleanup: Sculpt/Paint ED code: correct return constant types.

Mainly use false/true for bool, but also a few others.

No change in behavior expected.

Fix T66614: Text objects: Truncate overflow for non-top aligned text

Cleanup: correct naming IMAGE_Z_DEPTH

IMAGE_DEPTH is used for bit depth.

Fix T80520: Tris to Quads ignores UV delimit option

Cleanup: balance braces, spelling

Keep braces balanced where possible, even with ifdef's as it avoids
confusions with editors calculating correct indentation level &
finding matching brackets.

Fix T80993: Crash duplicating inactive workspace

We need to check for the property editor's runtime struct
before duplicating it.

Fix broken Windows buiilds after own recent commit in read/write code.

Usual issue of win32 not following POSIX standards.

Fix (unreported) wrong definition of `ssize_t` for windows.

Since at least MSVC2010 there is a `SSIZE_T` available for windows, use
it to typedef `ssize_t` on this platform.

Sanitize type 'size' parameters in our read/write file code

This patch tries to sanitize the types of our size parameters across our read
and write code, which is currently fairly inconsistent (using `int`, `uint`,
`size_t`...), by using `size_t` everywhere. Since in Blender file themselves
we can only store chunk of size `MAX_INT`, added some asserts to ensure that
as well.

See {T79561} for details.

Differential Revision: https://developer.blender.org/D8672

LibOverride: add checks to RNA collections editing utils.

Collections of liboverride data only support insertion of new items (and
deleting or moving those around). No operation on existing items from linked
data is allowed.

Reflect that in RNA functions used to edit py-defined RNA collections.

Note that this is not ideal currently, it does the job but feedback to
user is rather poor. Ideally add-ons should implement higher-level
checks for override cases in their operators.

Cleanup: Correct comment in newly added liboverride code for IDProp collections.