Blender Git Loki

Cleanup: Remove unused variables

Fix T79987: Crash when joining objects

Mistake in b077de086e14. I did the same fix for a few operators there,
but missed the object "Join" one.

The joining operator changes the layer content. So it must send a
notifier for that.
Before b077de086e14 that didn't cause a noticeable issue, because the
Outliner happened to listen to other notifiers (active/selection
changes) the operator sent and fully rebuilt its tree in response. Now
missing these notifiers can be more problematic, since we try to avoid
more rebuilds.

Added comments to the notifier types to avoid at least this pitfall.

Cleanup: rename iterators over sequences to be more clear about what they do.

No functional changes expected.

Merge branch 'blender-v2.90-release' into master

Fix critical bug in foreach ID looper of Scene data-block.

Since stone age of lib_query, the code would iterate over the current
list of active sequences (from a meta strip e.g.), and not over the
whole list of those.

This is a critical issue as it means in some cases (editing a meta strip
typically), some ID pointers would be missed/ignored by this foreach
looper, which is now at the center of most of our ID management code.

This caused a bug here at the studio, leading to loss of all sound IDs
used by sound strips when editing and undoing inside a meta strip, since
ID refcounting would not happen properly on strips using sounds outside
the meta-strip context during file reading of the undo steps.

To be backported to 2.83.

Differential Revision: https://developer.blender.org/D8671

Cleanup: spelling

Cleanup: use doxy sections for fcurve.c

Cleanup: remove f-string use

Cleanup: remove duplicated code from previously unnoticed merge conflict

`BKE_animdata_blend_expand` is called in `expand_id` already.

Refactor: move animdata code from blenloader to blenkernel

Refactor: move nla code from blenloader to blenkernel

Cleanup: remove LodLevel

This was part of the game engine and is not used anymore.

Reviewers: brecht

Differential Revision: https://developer.blender.org/D8666

Refactor: move fcurve/fmodifier code from blenloader to blenkernel

This is part of T76372.

Cleanup: use LISTBASE_FOREACH in readfile.c

GPUShader: Fix linking working even if one shader compilation failed

Linking without valid shaders works on some drivers. Avoid this case by
forcing linking step to return false.

Cleanup: GPU: Update classes comments

This should avoid confusion about what is a class and what is an opaque
pointer.

GPUShader: Make GPUShader* an opaque pointer to blender::gpu::Shader

This avoids the misleading inheritance.

Also cleanup by setting the blender::gpu::Shader as active shader to
avoid some casting.

GPUShader: Fix NULL string used as shader name.

The shader name is required with the latest changes.

GPUUniformBuf: GL backend isolation

This is in preparation of vulkan backend. We move all opengl
functionnalities behind an abstract class.

This also cleansup the "dynamic" ubo create and rename it to
`GPU_uniformbuf_from_list()`

Contains, no functional change.

Part of T68990 Vulkan support.

GPUUniformBuf: Rename struct and change API a bit

This follows the GPU module naming of other buffers.
We pass name to distinguish each GPUUniformBuf in debug mode.
Also remove DRW_uniform_buffer interface.