Blender Git Loki

Cleanup: use LISTBASE_FOREACH in writefile.c

Blenloader: move IDProperty read/write code to blenkernel

This is part of T76372.

Cleanup: remove `exec()` calls from custom property editor

Remove `exec()` and `eval()` calls from `WM_OT_properties_edit` where
possible. This not only results in simpler, cleaner code, but also
removes the necessity for `repr(value)` to evaluate to a Python
expression that in turn evaluates to `value` again.

No functional changes.

Reviewed By: campbellbarton

Differential Revision: https://developer.blender.org/D8658

Cleanup: split `BKE_scene_get_depsgraph()` into two functions

Split the depsgraph allocation into a separate function
`BKE_scene_ensure_depsgraph()`. Parameters are only passed to those
functions that actually need them. This removes the the "if that boolean
is `false` this pointer is allowed to be `NULL`" logic and more cleanly
decouples code.

No functional changes.

Cleanup: Reduce nesting of `scene_get_depsgraph_p()`

Reduce nesting by flipping conditions and returning early. It's now much
clearer that it's actually a linear function (rather than a nested one).

No functional changes.

Fix crash when accessing `view_layer.depsgraph` through BPY

For the sanity checks to work we don't actually need to check other
scenes. So this function can be simplified so that it does not require
a `Main *`.

Mistake in 5cc08510e0a6.

Cleanup: remove MeshBatchCache from MeshRenderData

Was noted as a hack, this can be passed as an argument instead.

UI: Fix panel collapse all behavior inverted

Ctrl click on a panel should collapse all other panels but leave that panel
expanded. In a recent cleanup commit that was mistakenly reversed.

UI: Cleanup in interface_panel.c

- Use const in some places where applicable
- Use consistent variable names in some places
- Use "r_" prefix for return arguments
- Declare variables in smaller scope where they are used

Cleanup: Use LISTBASE_FOREACH in editors/screen directory

Differential Revision: https://developer.blender.org/D8653

Fix incorrect notifier value

Wouldn't actually cause an issue since the value was unused within the
subtype bits.
Own mistake in dc2df8307f41.

Outliner: Avoid rebuilding tree on selection/active changes

We can avoid the rather expensive outliner tree rebuilds and only redraw
if nothing but the selection or active item changes. This should give a
bit of speedup for heavy scenes.

For this to work I had to correct a few notifiers, some were only
sending selection/active change notifiers that actually did things like
adding objects. I also added a more precise notifier type for when the
active collection changes. At the notifier subtype/action level we're
not even close to running out of bits, so this should be fine.
Also had to correct a wrong notifier check (was using `&` rather than
`==`).

Cleanup: Clang Tidy: Resolve readability-delete-null-pointer error

Merge branch 'blender-v2.90-release' into master

GPUShaderInterface: Fix use after free crash

Fix T79931: Infinite loop in scene "Full Copy" in 2.90.

Code dealing with object copy of master collection was bugy in case one
of the new object copy would get a name lesser than the original object,
leading to new copy being inserted before original one in lists.

Maniphest Tasks: T79931

Differential Revision: https://developer.blender.org/D8656

Fix T63675: Keying outside NLA strip not possible

Allow adding keys outside of the NLA strip, when Sync Length is
activated. Before this, an animator would have to exit tweak mode,
adjust the strip length, then enter tweak mode again.

Now the animator can freely insert and modify keys outside of the strip
bounds. They will never have to touch the strip bounds directly.

Reviewed By: sybren

Differential Revision: https://developer.blender.org/D7533

Cleanup: Mesh Filter invoke refactor

This moves the allocation for filter to separate functions, removes all
repeated calls to RNA_enum_get an fixes some other code quality issues.

Reviewed By: sergey

Differential Revision: https://developer.blender.org/D8639

GPUState: Use state setters inside selection code

This fixes T79945 Gizmos don't work in Edit Mode

DRW: Fix remaining glDisable