Blender Git Loki

Cleanup: Remove outliner statement with no effect

No functional changes. The memory dupalloc will already carry over the
flags.

Cleanup: use _fn for outliner callback functions

No functional changes.

Cleanup: fix some clang tidy warnings

Cleanup: use C++ style casts in various places

Fix compile error with WITH_INPUT_NDOF after last own commit

Caused by dcff28e1e7a8.

Cleanup: enable Clang-Tidy `bugprone-parent-virtual-call` rule

I added a single `NOLINT` exception with explanation.

No functional changes.

UI Code Quality: Use derived struct for HSV Cube buttons

For the main rationale behind this design, see 49f088e2d093. Further,
this removes users of uiBut.a1, which is a very ugly design
choice (hard to reason about).

Part of T74432.

Cleanup: enabled Clang-Tidy `bugprone-suspicious-missing-comma` rule

No functional changes because no code changed.

Cleanup: enabled Clang-Tidy `bugprone-not-null-terminated-result` rule

No functional changes because no code changed.

Cleanup: fixed Clang-Tidy `bugprone-suspicious-string-compare` warnings

No functional changes.

Merge branch 'blender-v2.90-release'

Fix previous commit, we first need to be sure we actually get a mesh...

Merge branch 'blender-v2.90-release'

Fix T79604: Switching to edit mode on boolean object runs out of memory.

Note that this is a dummy safe fix for now, far from optimal.

Cleanup: CMake warnings related to "find package" modules

Fix package name missmatch in a few module files. IE "ALEMBIC" was
defined in the file but the find_package commands used "Alembic"

Some modules state that they set and use the _LIBRARY variable but the
do in fact not do this. Removed these comments from those files.

Cleanup: enabled Clang-Tidy rule `bugprone-infinite-loop`

Enabling it and doing a full rebuild didn't cause any warnings, so nothing
else to do here.

No functional changes.

Cleanup: added explanation of why `incircleadapt` is allowed to be long

This is a followup of d4bd0789abb6e7805e07636232cec4480028f6d1, as it was
lacking a bit of an explanation.

No functional changes.

Cleanup: enable and silence Clang-Tidy readability-function-size

Enable Clang-Tidy's `readability-function-size` rule and add a few
`NOLINT` markers to explicitly silence warnings for three functions.
These functions are huge and would IMO benefit from splitting up, but
are hard to without intimate knowledge of the code.

At least by enabling the rule, we can start tweaking the values and
refactoring other functions that bubble up as being too long/complex.

No functional changes.

Cleanup: Nodes, silence Clang-Tidy readability-function-size

Add a `NOLINT` marker to explicitly silence a warning from Clang-Tidy's
`readability-function-size` rule for the `node_type_base()` function.
This function is indeed huge, but that is because a lot of macros are
expanded. Before expansion things are still not small, but still
understandable & expandable.

No functional changes.

Cleanup: Clang-Tidy. readability-non-const-parameter in pixel drawing