Blender Git Loki

Cleanup: Make UI tree-view item constructor explicit

Constructors that can be called with a single argument should be
explicit, unless there's a reason not to, to avoid unintended
constructions.

UI: Add padding to the left of tree-rows labels without icon

The label was placed right at the left border of the row highlight,
which looked weird. So add some padding to tree-row labels without icon
or collapse chevron, which makes it look more polished. As additional
benefit, it alignes the labels better with icons of other rows on the
same tree level. And the padding makes it more clear that a child is
indeed a child, not just a sibling without icon.

Cleanup: Move 2.80 doversion code under a MAIN_VERSION_ATLEAST check

Fix: missing cache invalidation when there is only one spline

This fixes T92511, but there is still the more general problem
described in T92508.

Fix T92427: Adding new nodes does no edge-panning

Unlike translating existing nodes [which disables cursor wrapping and
enables edge-panning instead since rBSa1cc7042a74], adding new nodes
would still show the old behavior of cursor wrapping.

This has been disabled for the case when the node whould be added
outside (due to menus overlapping other editors).

Now enable edge-panning for adding new nodes as well and make sure
this only starts once the mouse has returned into the inside rect once.

Maniphest Tasks: T92427

Differential Revision: https://developer.blender.org/D13005

Fix T92494: Node Editor dot grid not respecting display resolution scale

This seems wrong and was especially noticeable since transform snapping
does account for it (which was reported in T92494).
Now divide the `DotGridLevelInfo` `step_factor` by the default of 20 for
`U.widget_unit` and scale it later by the actual interface scale.

note: when zooming, this will still always snap to the smallest dot
level (not sure, with a bit more work it could be possible to only snap
to the lowest visible level after fading?)

Maniphest Tasks: T92494

Differential Revision: https://developer.blender.org/D13002

Cleanup: Rename `scene.c`'s `FOREACHID_PROCESS` macro to `FOREACHID_PROCESS_IDSUPER`.

Follow-up of rBf11ed418e5fa.

Fix T92402: copy_particle_systems use_active fails outside the
Properties Editor

Similar to rBf9308a585ecd, use `psys_get_current` if we cant get the
active psys from context (which is only defined for the Properties
Editor). Other solution would be to define a "particle_system" context
member in other editors, but for now, stick with the simplest solution.

thx @mano-wii for additional input

Maniphest Tasks: T92402

Differential Revision: https://developer.blender.org/D13000

Fix T88443: Lattice still shows edges with "Bounds" display type

Lattice wires are drawn as part of "Extras". Unlike the other types
details (Cameras, Lights, Lightprobes and Speakers), Lattices actually
have boundingboxes defined, so hide the lattice wires if only the
boundingbox is requested.

Maniphest Tasks: T88443

Differential Revision: https://developer.blender.org/D11343

Cleanup: use UNUSED_FUNCTION(..) attribute

Otherwise this function may fail to compile when other changes are made.

Cleanup: use 'use_' prefix for RNA naming in grease pencil modifiers

Cleanup: remove underscore prefix from variable

Avoid using underscore prefix since these typically mean the variable
shouldn't be accessed directly (it may be accessed from a macro,
or memory on the stack which is assigned to a pointer).

In this case a more meaningful name can be used for the argument
that was shadowed.

Cleanup: add missing break

Cleanup: clang-format, clang-tidy, spelling

Docs: add docstring for wmWindowManger.winactive

Also justify rounding up font width.

Nodes: Cleanup code for header underline alpha

Use `UI_GetThemeColorBlend4f` instead of manually setting alpha opaque.

win/make.bat: Add svnfix convenience target

SVN seems to die randomly *a lot* during
large updates for some users, and I'm no
closer to finding out why that keeps happening.

"The internet" seems to imply some AV vendors
may be at fault here but nothing conclusive.

The solution however is repeatedly running
`svn cleanup`and `svn update` in the library
folder to repair the corruption and finish the
update.

This change adds a small convenience helper
to automate the repair.

This is done inside the make.bat code rather
than the shared python based update code, since
python lives in the library folder and may
or may not exist when this corruption occurs.

Nodes: Cleanup setting node header alpha

Always draw header opaque, set transparency only once after getting
the color. Helps to unify the color and alpha values.

Asset Browser: Reduce paddings & margins between previews

The paddings and margins were more than needed, this reduces them a bit. That
way space is used more efficiently, the small differences add up so that more
items fit into a row.
The File Browser should not be affected.

Before/after comparisons:
{F11529986} {F11529988}
{F11529987} {F11529989}

Knife: Preserve right click cancel functionality

Currently, the knife does not use right click cancel.
It causes users to accidentally delete entire cuts easily.

This patch allows right click cancel when no cuts have been made.
This makes it consistent with other tools when switching between them.
More info: https://devtalk.blender.org/t/gsoc-2021-knife-tool-improvements-feedback/19047/175?u=hobbesos