Blender Git Commit Log

Git Commits -> Revision 1af6e0d

September 6, 2021, 07:24 (GMT)
Fix T90772: Image Editor not sampling color from the the currently
selected pass

Caused by {rBebaa3fcedd23}.

Seems this above commit assumed an ImageUser's multi_index is only used
for Multiview/Stereo? This is not the case, multi_index also stores the
index for layer/pass combination.

If we call both BKE_image_multilayer_index and BKE_image_multiview_index
(even though this is not appropriate/needed for multilayer images?), we
might end up overwriting multi_index again.

note: looking at this I was also wondering why we update the ImageUser
in image-buffer-aquiring funnctions [and not from the UI, e.g.
template_image_layers, but that is a whole different story I guess, see
comment in T90772 as well]

note2: this could also use a utility function (this is not the only
place where this is done), this is fo a cleanup commit.

Maniphest Tasks: T90772

Differential Revision: https://developer.blender.org/D12267

Commit Details:

Full Hash: 1af6e0daaf6ba47c083e9cd451fe145f7545bc79
Parent Commit: 52fdf42
Committed By: Jeroen Bakker
Lines Changed: +3, -1

1 Modified Path:

/source/blender/draw/engines/image/image_engine.c (+3, -1) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021