Blender Git Commit Log

Git Commits -> Revision 4f3233d

Revision 4f3233d by Pablo Dobarro (master)
July 27, 2020, 19:58 (GMT)
Fix T78242: Crash when using a Sculpt color tools that needs connectivity for the first time

When there is no color layer available,
BKE_sculpt_update_object_for_edit creates a new one and tags the mesh
with ID_RECLAC_GEOMETRY, so this layer is inmediatly available when the
tool starts. This also deletes the PBVH and when it is created again in
BKE_sculpt_update_object_after_eval, the pmap is not initialized, making
the tool crash.

This moves the color layer creation to a separate function outside
BKE_sculpt_update_object_for_edit, which now runs after the color
layer is available, so it won't need to update again and the pmap will
still be available when the tool is used.

Reviewed By: sergey

Maniphest Tasks: T78242

Differential Revision: https://developer.blender.org/D8135

Commit Details:

Full Hash: 4f3233dd536e8839c304dd34cd8aec89bfd8ca34
Parent Commit: 2584a2a
Lines Changed: +35, -14

4 Modified Paths:

/source/blender/blenkernel/BKE_paint.h (+4, -0) (Diff)
/source/blender/blenkernel/intern/paint.c (+18, -12) (Diff)
/source/blender/editors/sculpt_paint/sculpt.c (+8, -1) (Diff)
/source/blender/editors/sculpt_paint/sculpt_filter_color.c (+5, -1) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021