Blender Git Commits

Cleanup/simplify/fixes BKE_object_is_libdata and BKE_object_obdata_is_libdata.

Removed checks for ob->proxy from the equation, you can totally have proxy objects
linked into another .blend file!

Replace of (id->lib != NULL) check by meaningful macro.

Idea is to replace hard-to-track (id->lib != NULL) 'is linked datablock' check everywhere in Blender
by a macro doing the same thing. This will allow to easily spot those checks in future, and more importantly,
to easily change it (see work done in asset-engine branch).

Note: did not touch to readfile.c, since there most of the time 'id->lib' check actually concerns the pointer,
and not a check whether ID is linked or not. Will have a closer look at it later.

Reviewers: campbellbarton, brecht, sergey

Differential Revision: https://developer.blender.org/D2082

writefile: simplify outliner treestore workaround

Instead of keeping a list of allocations, write to unique addresses
based on the BLI_mempool address since we know this is unique.

Cleanup: redundant 4th index in sculpt PBVH

Since moving to MLoopTri this is no longer needed.

Dyntopo: optimize edge collapsing

Checking if faces exist was a bottleneck,
use a simpler version of this function for triangles.

Gives approx 1.6x overall speedup (when many edges are being collapsed).

Cleanup: group dyntopo utility functions

Transform Snap: Replace pixel limit w/ 'dist_to_ray_sq'

When snapping to edge/vert, check the distance to the ray
instead of the screen-space pixel projection.

This also corrects the conversion of `dist_to_ray_sq` to `dist_px` which was being done incorrectly.

While this change was planned, it fixes T48791, caused by error in b01a56ee.

Code cleanup: for Cycles compatible panels, use exclusion rather than inclusion list.

This shortens the list, and Blender render specific panels are added less often
than other panels anyway, so less chance to miss things.

Render border: don't disable when drawing around the entire camera.

Differential Revision: https://developer.blender.org/D712

Render border: skip unnecessary uncropping if the border covers the entire image.

Render border: make it work together with with cache result / save buffers / full sample.

Differential Revision: https://developer.blender.org/D2080

Dyntopo: missing PBVH update collapsing an edge

PBVH-nodes attached to the vertex to be deleted were updated,
but not nodes attached to the other vertex in the edge.

Dyntopo: avoid redundant vector copy

Dyntopo: inline lookups, remove type check

This was checking vert/face for every lookup,
so far the type is always known, do a direct lookup instead.

Dyntopo: use inline iterators

Gives small performance boost.

Dyntopo: compare masks when collapsing

Was just checking the value of the first

Dyntopo: verify had over zealous asserts

Cycles: remove extended precision hacks, no longer needed with SSE2 requirement.

Differential Revision: https://developer.blender.org/D2079

Fix a few compiler warnings on OS X / clang.

Two were actual bugs, though they existed only in unused code:
* In Freestyle it was unintentionally copying a scene rather than referencing it.
* In BLI_array_store_is_valid there was use of uninitialized memory.

Fix use of uninitialized variable introduced in fix for T48755.