Blender Git Loki

Cleanup: Miscellaneous improvements in wm directory

- Reduce variable scope.
- Use LISTBASE_FOREACH macros.
- Return early in some cases to reduce to reduce indentation.

Fix T81594: Unable to reassign effect inputs

This was caused by canceling operator if strip has more than 0 inputs.
Logic should be reversed - cancel only if strip has 0 inputs.

BKE_sequencer_render_loop_check() arguments had to be sanitized because
seq_effect_find_selected() can set seq1,2,3 to NULL

Reviewed By: sergey

Differential Revision: https://developer.blender.org/D9197

XR: Add "selection eye" session setting

The "selection eye" is the XR eye (view) used for 3D-to-2D projection.
Its parameters are used to override the window view when selecting
with VR controllers.

Cleanup: Reduce variable scope in screen directory

Also return early and use LISTBASE_FOREACH in a few places

Cleanup: Reduce variable scope in area.c

UI: Tweak decimate modifier layout

- Expand the "Type" toggle at the top. This is consistent with other
modifiers where there is a "Type" option at the top. It conveys the
property's importance and makes it faster to switch it.
- Expand the "Delimit" option vertically so the text isn't squashed.
There isn't enough space on one line for this, and is has to be
expanded because more than one option can be selected. This is also
consistent with how "multi-select" enums are often displayed, like
the 3D view snapping settings.

| Before | After |
| {F9000996} | {F9000985} |

UI: Align related properties

The start and end frame properties are generally aligned in one block.

Property Search: Reset panel expansion when exiting search

This patch implements panel expansion saving and resetting for property
search. While search is active, the panel expansion is based on whether
or not it has a search result. When the search finishes, the panel
expansion returns to its state before the search started. However, any
panels interacted with during the search won't reset their expansion.

This requires adding a new runtime flag for panels to store whether to
use search result status as expansion. It also requires better handling
for animation when panel expansion changes with another new runtime flag.
`UI_panel_is_closed` gets the search-dependent expansion, but it is
intentionally not used to access expansion in every case-- sometimes it's
necessary to use `PNL_CLOSED` directly.

Differential Revision: https://developer.blender.org/D8984

Cleanup: reduce variable scopes

Cleanup: reduce variable scopes

Fix misuse of alloc inside a loop

Alloc will only free its memory when the function is returned.

Issue introduced in c866075dfbd9. Thanks Sergey for spotting this.

Animation: Snap Cursor Value operator

Add operator to snap the 2D Cursor value to selected keyframes. This is
doing almost the same as the "Cursor to Selected" operator, except that
it doesn't affect the current frame, just the Y-coordinate (the value)
of the 2D cursor.

The "snap cursor" operators are added to the Key ? Snap menu and to the
Snap pie menu. This means that these menus are now extended in meaning,
to not only mean "snap the selected keyframes to the cursor", but also
for some options "snap the cursor to selected keyframes".

This fixes T76596.

Cleanup: Animation, split up frame jump operator

Split up `GRAPH_OT_frame_jump` exec function and added some local variables
to give names to the cryptic `ked.f1`, `ked.f2`, and `ked.i1`.

No functional changes.

Cleanup: clang-tidy

Fix (reported by studio team) crash in relocate lib code.

We do not always find a matching ID in new library.

Fix T81027: Multires objects in sculpt mode can't be linked via collections.

Just clear all non-object mode flags from linked objects at read time.

Reviewers: brecht

Subscribers:

Fix T81591: Align view to active is not working in sculpt mode

Remove sculpt/paint checks in getTransformOrientation_ex
This code goes back a long time (early 2.5x). I couldn't find any
reason why sculpt/paint checks were being made.

This makes the following changes:

- When in object mode, the object must be selected.
Since this function typically operates on the selected items.

- When in paint/particle modes, the objects matrix is always
used regardless of selection, since object selection can't be
controlled in these modes.

- When there is no active object, the first selected object is no
longer used as it's quite an arbitrary decision & not something
done elsewhere with objects in Blender.

Fix T54526: Data Transfer modifier's Max Distance field working strangely.

Based on investigation by Philipp Oeser (@lichtwerk) and solution by
Alexander Gavrilov (@angavrilov) in D5206, thanks!

EEVEE: SSR: Fix unreported smoothstep instability when border factor is 0

From the GLSL documentation: `Results are undefined if edge0 ? edge1.`
This is the case without this patch.

UI: Make node theme settings to conform to UI rules

Basically first letter of (most) words is to be capitalized.

These settings (Noodle curving and Grid levels) had this wrong since
their first commit (2011 and 2020 respectively).