Blender Git Loki

GPencil: Fix transform memory issue

Use an enum type for solver in boolean modifier.

This matches what was done in a previous commit for the tool.
It makes it easier to associate a tooltip with each choice.
For this branch, I have the default solver be the Exact one;
when we merge to master, we will have to decide the best default.
Make format caught a coouple other files, sorr for not doing those
earlier.

Cleanup: GPU: Update classes comments

This should avoid confusion about what is a class and what is an opaque
pointer.

GPUShader: Make GPUShader* an opaque pointer to blender::gpu::Shader

This avoids the misleading inheritance.

Also cleanup by setting the blender::gpu::Shader as active shader to
avoid some casting.

GPUShader: Fix NULL string used as shader name.

The shader name is required with the latest changes.

GPUUniformBuf: GL backend isolation

This is in preparation of vulkan backend. We move all opengl
functionnalities behind an abstract class.

This also cleansup the "dynamic" ubo create and rename it to
`GPU_uniformbuf_from_list()`

Contains, no functional change.

Part of T68990 Vulkan support.

GPUUniformBuf: Rename struct and change API a bit

This follows the GPU module naming of other buffers.
We pass name to distinguish each GPUUniformBuf in debug mode.
Also remove DRW_uniform_buffer interface.

Cleanup: use LISTBASE_FOREACH in writefile.c

Blenloader: move IDProperty read/write code to blenkernel

This is part of T76372.

Add newly creates faces to imported faces and dissolve edges.

The code so far imports triangles, but also fills holes.
Committing since it doesn't crash.

test file:

```
o plane_with_hole
v 2 2 0
v 2 -2 0
v -2 -2 0
v -2 2 0

v 1 1 0
v 1 -1 0
v -1 -1 0
v -1 1 0

f 4 1 2 3 4 8 5 6 7 8 4
```

Fix tessellate crash due to wrong Vector size.

Also fix crash due to out of bound vertex indices.

Cleanup: remove `exec()` calls from custom property editor

Remove `exec()` and `eval()` calls from `WM_OT_properties_edit` where
possible. This not only results in simpler, cleaner code, but also
removes the necessity for `repr(value)` to evaluate to a Python
expression that in turn evaluates to `value` again.

No functional changes.

Reviewed By: campbellbarton

Differential Revision: https://developer.blender.org/D8658

Cleanup: split `BKE_scene_get_depsgraph()` into two functions

Split the depsgraph allocation into a separate function
`BKE_scene_ensure_depsgraph()`. Parameters are only passed to those
functions that actually need them. This removes the the "if that boolean
is `false` this pointer is allowed to be `NULL`" logic and more cleanly
decouples code.

No functional changes.

Cleanup: Reduce nesting of `scene_get_depsgraph_p()`

Reduce nesting by flipping conditions and returning early. It's now much
clearer that it's actually a linear function (rather than a nested one).

No functional changes.

Commit as it is ngon-tessellate.

The code is totally untested and will very likely crash.

GPencil: Fix handle lines display

Tests: detect memory leaks in automated tests

A memory leak should be considered a bug. Therefore, it makes sense to fail tests when they contain memory leaks.

Differential Revision: https://developer.blender.org/D8665

Fix crash when accessing `view_layer.depsgraph` through BPY

For the sanity checks to work we don't actually need to check other
scenes. So this function can be simplified so that it does not require
a `Main *`.

Mistake in 5cc08510e0a6.

Use draw manager cursor

Merge branch 'greasepencil-edit-curve' into soc-2020-greasepencil-curve