Blender Git Loki

Cleanup: move click/drag events to functions

Simplifies future changes to dragging checks and avoids
each check for drag using slightly different logic.

Cleanup: rename callbacks to match the struct member name

GPencil: Cleanup - Remove storage Grid matrix and replace with local variable

Now the matrix is copied when creating shading group and don't need to be saved in storage.

Cleanup: Remove duplicated comment from previous commit

GPencil: Rename viewmatrix field to parent_obmat

The name of the field was not clear about the use.

GPencil: Cleanup code to avoid double matrix copy

Thanks @fclem for catching the problem.

Snap: add support for meshes generated from other types of objects.

Curves with modifiers generate a mesh internally.
These can be used for raycasting.

Fix T64817: Active tool gizmo doesn't respect toggle

Error in 14884cda1ff56

D4973 by @cto.abid

Fix T64995: box and circle select summary in Grease Pencil dopesheet.

The issue is that generic ANIM_animchannel_keyframes_loop can't
handle non-FCurve keyframes, so every selection operator does
its own looping over special key types, and the box and region
select operators didn't have code to deal with the summary.

This adds code to handle that in a similar way to other ops.

Fix T51133: Bad performance with texture painting depending on multi-thread settings.

This is more of a temp urgent hack than a proper fix, chenages required
for the later are too involved for 2.80 at that point of time and will
be done later.

That commit merely keeps the whole existing logic for 3D painting
textures, but instead of re-creating a pool of threads for *every* (!)
stroke evaluation (i.e. mouse move event during painting), we instead
use Blender's task scheduler.

That remains sub-optimal, there are likely more improvements possible in
that code, but it should address the main issue reported (which is
presumably caused by windows thread launching being rather heavy process).

Fix T65275: missing dereference

Outliner: Correct outliner width computation

Before it was not possible to see everything in the outliner
when there are e.g. long icon rows. This is because Blender
did not allow panning the view to the right, since it did not
know the actual width.

Most of the code to compute the width correctly was there already,
but there were a couple of issues that made it not work.

* The tree width was computed before the tree was drawn.
This does not work, since the width is only known, after
it is drawn.
* Every `TreeElement` stores its right-most position in `xend`.
However, in the current code, the `xend` of e.g. an object is
the position where the text ends. The `xend` of the icons
is stored in the sub-tree-elements. Therefore, to compute
the maximum width, you may not skip the closed tree elements.
* The current drawing code had an early exit when the icon row
would not be visible anymore. This also skipped the calculation
of `xend`. So it would work correctly, when the icon was visible
a little bit, but not when it was not visible at all.

This patch fixes these issues. So even in more complex files, the
width is computed correcly. At least I haven't found a case, where
it does not.

Unfortunately, some optimizations had to be turned off, to make
it correct.

Reviewers: brecht

Differential Revision: https://developer.blender.org/D4887

DrawManager: Cycles+GPencil

Fix for GPencil and Cycles Render draw type. GPencil objects were only
shown when overlays were turned on. The cause of this is an
optimization we did to not populate any draw engine when an
external renderer was used with overlays turned off.

This will check if there is any visible GPencil object in the scene. if
so it will still perform the loop.

`DEG_id_type_any_exists` can check if any object of a certain type_id is in the
result. This check is also being used to check if there are any
visible grease pencil objects as a precheck in `DRW_render_check_grease_pencil`.

Reviewed By: brecht, fclem, antoniov

Maniphest Tasks: T65191

Differential Revision: https://developer.blender.org/D4962

Keymap: Fix missing start/end shortcuts in Sequencer

Set these in the shared animation editor keymap instead

Fix T63383: macOS: Right-clicking the file name on the title bar
doesn't work as expected when the path includes a whitespace character

File path didn't need to be escaped.

Depsgraph: Fix IDs being remapped in original compositor

Happens with files from T65223.

Caused by CoW scene still pointing to the original compositor.
Happens when scene was referenced for parameters only.

Cleanup: Group depsgraph building nodes

Markers: fix error in previous commit

Fix: Hair Length was using wrong unit

Cleanup: Remove unused marker operator wrappers

The wrappers do nothing anymore, because keymaps can
have poll functions now.