Blender Git Loki

Assets: Replace duplicated asset library reference type from DNA

Since recently it's possible to access assets from outside the
File/Asset Browser, via the asset view template. So we are slowly
moving away from file space specific code to dedicated asset system
code. I introduced `AssetLibraryReference` as a duplicate of
`FileSelectAssetLibraryUID`, with a plan to delete the latter in a
separate cleanup commit. That's exactly what this commit is.

This will cause Asset Browsers to open with the default "Current File"
Asset Library. We could avoid that, but it's a minor issue really.

Cleanup: Centralize/unify asset library reference from/to enum code

This was an open TODO, I wanted to have code for translating asset
library references from and to enum values in a central place, and
access that in the same way from both the Asset Browser and the
Workspace RNA code.

* Adds own file for the related functions.
* Adds doxygen comments.
* Updates RNA callbacks to properly use these functions.
* Let these functions call each other, avoid duplicating logic.

Fix incorrect use of BLI_assert with error strings

Some asserts were never raised because of invalid checks.

Cleanup: replace BLI_assert(test || !"text") with BLI_assert_msg(test, text)

Cleanup: correct the comment in ghost

The same comments were written in clientToScreen and screenToClient in
GHOST. I corrected them.

Ref D11986

Fix bug in assert in delaunay test.

Assert was trying to say x coords of arcs lined up, and didn't do that.

Cleanup: Split set_preview_visibilty.

Cleanup: replace BLI_assert(!"text") with BLI_assert_msg(0, "text")

Cleanup: spelling

Cleanup: replace BLI_assert(0 && "text") with BLI_assert_msg

Fix T89881: ignore unavailable sockets when searching for link cycles

Fix compile issue.

Fix i18n utils_cli mistake.

Reported by James Monthea (@jmonteath), thanks.

Cleanup Preview rendering: Separate world preparation.

Small cleanup that moves world preparation out of scene preparation.

Cleanup: use named enum types.

Added ePreviewRenderMethod and ePreviewType.

Cleanup: replace NB with NOTE in comments

UI: Use more descriptive wording for particle modifier conversions

Currently the wording is a bit unclear: it doesn't specify //what// the particles will be converted into. This clarifies it by stating what the particles will be converted into: they will either be converted to a mesh or the instances will be made real.

Reviewed By: Blendify

Differential Revision: https://developer.blender.org/D11795

UI: Fix Cycles Materials menu Layout

Fix an incoherence between the Eevee Materials menu and the Cycles Materials menu :

Eevee :
{F10230448}

Cycles :
{F10230449}

Simply Fixed by replacing the Cycles UI code by the Eevee UI code.

Thanks to @Brainzman for helping me create this diff and translate

Reviewed By: Blendify

Differential Revision: https://developer.blender.org/D11979

Fix API doc generation after recent context additions

Fix T89827: Attribute transfer node crash on mesh with no faces

Just add a check for whether the mesh has faces when retrieving an
attribute on the corner domain. In the future there could be an info
message in the node in this case, since maybe it's not intuitive.