Blender Git Loki

UI Code Quality: Refactor panel drawing function

The existing panel drawing function was a bit convoluted with dependent
conditions in different scopes, redundant and unecessary computations,
and un-helpful naming.

This commit separates the function into two parts, the backdrop and the
widgets. It also improves naming and uses const where possible, and in
general cleans up the code.

There are some slight visual changes, mostly with the placement of the
drag icon, which moves a bit downward to be centered with the triangle
icon. The black rectangle displayed while dragging is also removed.

Fix pin icon in Properties not right-aligned after zooming

The logic for separator-spacers (used here for right-alignment) didn't take
region scaling into account. Usually that's not an issue because they are
otherwise only used in headers which can't zoom.

Fix pin icon in Properties not right-aligned after zooming

The logic for separator-spacers (used here for right-alignment) didn't take
region scaling into account. Usually that's not an issue because they are
otherwise only used in headers which can't zoom.

Merge branch 'blender-v2.91-release'

Fix: Outliner hierarchy line width variations

During some operators like rotate in grease pencil edit mode the
hierarchy lines in the outliner would draw twice as thick. Set the width
before drawing the lines in the outliner.

Differential Revision: https://developer.blender.org/D9589

Fix T82777: Some transform modes using incorrect default orientation

Some modes were always using `"Global"` orientation as the default.

Fix transform redo panel showing only the first custom orientation

The error was introduced in rBf470a02afaea, but the problem is in
`ED_transform_calc_orientation_from_type_ex`

Fix exact boolean coplanar problem due to inexact transform.

This is an addendum to previous boolean fix, where the object
transformation was "cleaned". Now the operand one is too.
This fixes the issue shown in the video in T82301 when you move
a column around the XY plane with the top and bottom faces
supposedly coplanar with a cube. The transformation matrix when
you do that has a tiny offset in the z component.

Merge branch 'blender-v2.91-release'

Fluid: Revert changes from T82488

Scaling of forces needs more work. Before making changes to them it would be nice to have a setup, that works physically correct across multiple modifiers (cloth, rigid bodies, fluid).

This will be a to do for 2.92.

Merge branch 'blender-v2.91-release'

Fix T82810: UV Editor, Crash with switching between single image and UDIM tile

Active tile could be NULL when it was on the second tile before
switching back and forth between the Image/UDIM.

In the future we might also check that the active_tile_index is always
valid.

Fix T82586: Sculpt normals not updating with EEVEE enabled

The root cause of this bug is that the function that updates the PBVH
normals is drw_sculpt_generate_calls. As now both the overlays and
mesh can be drawn without using pbvh drawing, the normals were not
updating. This patch forces a normals updates also in the no PBVH
drawing code path of the overlays. This was affecting both shading and
sculpt surface sampling in both flat and smooth shading modes.

Having the sculpt normals being updated by the drawing code is a wrong
design which also causes other issues like:

Brushes that sample the surface and do multiple stroke steps between

redraws will sample invalid normals, creating artifacts during the
stroke clearly visible in some brushes.

Brushes that do not need to sample the surface update the normals on

each redraw. This affects performance a lot as in some cases, updating the
normals takes more time than doing the brush deformation. If flat shading
is being used, this is only necessary to do once after the stroke ends.

Reviewed By: fclem
Differential Revision: https://developer.blender.org/D9535

Merge branch 'blender-v2.91-release'

Fix T82800: Changing settings from a pie menu doesn't add undo steps

Pie menu had inconsistent behavior for dragging & releasing the key
compared to clicking on the button.

This was caused by the `onfree` argument being set to true,
preventing the button from running callbacks such as setting
up undo data & auto-keyframe

This argument should only be used when freeing the button,
set this to false as is done for regular menus.

Merge branch 'blender-v2.91-release'

Fix undo UI text containing shortcuts & newlines

- Shortcuts were being shown in the undo history.
- Multi-line tool-tips now only use the first line.

Merge branch 'blender-v2.91-release'

Fix grease pencil draw mode icon color in outliner

ICON_GREASEPENCIL was defined as an object data icon when it was used as
a mode icon. This caused it to draw green in the outliner.

Fix wrong grease pencil datablock icon in file browser

The datablock shown in the file browser was the draw mode icon rather
than the datablock icon.