Blender Git Loki

Fix integer overflow in BLI_mempool_as_arrayN()

`(size_t)(int * int)` will actually cast overflown integer to size_t,
which isn't what was intended here. Correct thing would be to cast
in the following manner `(size_t)int * int`.

In this particular case can as well use function which is designed to
allocate an array of memory without overflow.

Cycles: cleanup warning

Cleanup: Collection: Move to IDTypeInfo, and remove unused BKE API.

Note: we still need BKE_collection_free since we call it from scene.c.

Cleanup: Use the SCULPT_ prefix in all sculpt_intern functions

Cleanup: bScreen: Move to IDTypeInfo and remove unused BKE API.

Cleanup: use ELEM macro for path slash checks

Fluid: Revert bc2ce31d7940 (changes to open boundaries)

Changes from that commit turned out to be unstable.

Fix T73842: UI: add cloth collision settings to Hair Dynamics panel

Since hair collisions were integrated with the cloth solver
(rBd42a7bbd6ea5), there are a couple of relevant settings which were not
exposed to the User:
- Collision Quality
- Minimum Distance (this was reported in T73842, default of 0.015m was
still limiting in certain scenarios - this can now be made smaller)
- Impulse clamping
- Collision collection

This will add a 'Collisions' panel to Hair Dynamics with those settings

Note: in contrast to 'real' cloth, self-collisions are not supported for
hair

Maniphest Tasks: T73842

Differential Revision: https://developer.blender.org/D7032

Cleanup: bNodeTree: Move to IDTypeInfo and remove unused BKE API.

Improve modifier error message with sculpt mode

Make it obvious that this relates to being in sculpt mode.

ref T74489

Maniphest Tasks: T74489

Differential Revision: https://developer.blender.org/D7044

Cleanup: tweak Cycles #includes in preparation for clang-format sorting

Cleanup: avoid use of BLI_cleanup_dir

Some cases don't need to add the trailing slash.
Use BLI_cleanup_path in this case.

Documentation: added bpy.msgbus description and examples

The `bpy.msgbus` namespace was not included in the documentation generation.
I've added it, and ported Campbell's examples from P563.

Cleanup: Message bus, removed incorrect return type from docstring

The docstring was likely copy-pasted, and the return type was not adjusted.
Since the `bpy.msgbus.subscribe_rna()` returns nothing, I just removed the
return type documentation.

Cleanup: remove BLI_cleanup_file

In practice, references to files rarely have trailing slashes
(by accident). Remove this function in favor of BLI_cleanup_path.

Cleanup: spelling

Fix using wrong property name for preserve face sets when remeshing

Spotted by Roel Koster in the initial face set commit.

Nodes: fix writing socket default values to file

Previously, `writedata` was used to store `bNodeSocket->default_value`.
There are a couple of issues with that:
* Breaks if someone tries to load the file on a big endian system (afaik).
* There is a `/* do not use for structs */` comment on `writedata`.
* Depends on `MEM_allocN_len` which should be avoided in my opinion.
* Now it is more apparent, that this should be handled by callbacks as well.

The part in `readfile.c` should work just fine still. I could also do a case
distinction there, but the code would be the same for every case for now.
Just `sock->default_value = newdataadr(fd, sock->default_value);`.

This might change, if we want to store more complex socket type specific data
that does not fit into a single struct.

Differential Revision: https://developer.blender.org/D7039

Reviewers: brecht

CodeCleanup: Added View3DShading enums

Added the core enums that workbench draw engine uses.

Cleanup: Brush: Move to IDTypeInfo, and remove unused BKE API.