Blender Git Loki

Refactor: move remaining ViewLayer .blend I/O to blenkernel

Ref T76372.

Refactor: move sequencer modifier .blend I/O to sequencer module

Ref T76372.

Refactor: move LightCache .blend I/O to eevee_lightcache.c

Ref T76372.

Cleanup: Alembic, simplify expression

Change `1 + current_mat++` to `++current_mat`.

No functional changes.

Cleanup: Alembic, simplify material assignment code

Refactor material assignment code such that:
- `build_mat_map()` just returns the built map (instead of relying on
modifying a map passed as parameter),
- `LISTBASE_FOREACH` is used to loop over a `ListBase` (instead of a
hand-crafted for-loop),
- just `return` when not enough material slots can be created (instead
of setting a boolean to false, then doing some useless work, then
checking the boolean),
- reorder some code for clarity, and
- rename `mat_map` to `matname_to_material` so that the semantics are
clearer.

No functional changes.

Refactor: move Paint .blend I/O to blenkernel

Ref T76372.

Cleanup: Clang-Tidy, readability-redundant-member-init

Fix T82457: Python error when clicking on a tool in the viewport

Ths variable was initialized for false, while it was expected to be
true.

Cleanup: Use nullptr everywhere in fluid code

Switched from NULL to nullptr.

Fix T82407: Negative number input gives syntax error for velocities and
accelerations

Caused by rB45dbc38a8b15.

Above commit would place parentheses surrounding a block until the next
operator was found.
For velocities and accelerations though, the '/' in 'm/s' or 'ft/s'
should not be considered an operator.

Maniphest Tasks: T82407

Differential Revision: https://developer.blender.org/D9467

Clang Tidy: Expand modernize category

Gives an idea of which warnings are affecting Blender code base.

Fix Outliner editbone selection with 'Sync Selection'

When editbones were selected from the Outliner (and they were connected
to a parent) with the 'Sync Selection' option turned ON, they could not
get duplicated.

For duplication to work, the (connected) parent bone's tip also has to
be selected [which was not the case when selection is done from the
Outliner under above circumstances]. The reason being that
armature_duplicate_selected_exec ->
ED_armature_edit_sync_selection clears the BONE_ROOTSEL flag if the
parent bone's BONE_TIPSEL is not set.

Caused by rB71eb65328078 btw.

The correct "parent-tip-selection" would actually happen in activation
- `tree_element_active_ebone`
-- `tree_element_active_ebone__sel`
but for 'Sync Selection' this happens [also] in
- `outliner_sync_selection_from_outliner`
-- `outliner_select_sync_to_edit_bone`
which did not do the "flushing" to the parent bone's tip

Now use existing dedicated function for this.

ref. T82347

Reviewers: Zachman

Differential Revision: https://developer.blender.org/D9470

Fix T82364: Widget anim state not updated when deleting channel in Graph Editor

So a keyframed e.g. location slider would stay yellow/green even if its
corresponding channel was removed.

Needs a appropriate notifier so the listeners (e.g.
buttons_area_listener, view3d_buttons_region_listener) would cause a
redraw.

Maniphest Tasks: T82364

Differential Revision: https://developer.blender.org/D9438

Fix T82387: Crash loading file saved with recent master in old versions

This fix makes sure new files save `wmWindow.global_areas` under a different
name, so old Blender versions don't recognize and 0-initialize it.

Since enabling global area writing (ef4aa42ea4ff), loading a file in old
Blender versions would cause `wmWindow.global_areas` to be read, because there
was already reading code for it and `ScrAreaMap` was in SDNA.
However the `ScrArea.global` of the global areas would be NULL, because it was
*not* in SDNA (`ScrGlobalAreaData` was excluded).
Now, issue is that the code assumes that areas in the global area-map have a
valid ScrArea.global pointer.

Think this was a mistake in rB5f6c45498c92. We should have cleared all this data
on reading, until the global area writing was enabled.

Differential Revision: https://developer.blender.org/D9442

Reviewed by: Brecht Van Lommel

Refactor: move wmWindowManager .blend I/O to IDTypeInfo callbacks

Cleanup: use if/else check for property poll

Cleanup: add missing doxygen group

CMake: configue_file() to pass strings for build-info

Using configue_file(..) would have avoided the breakage from
1daa3c3f0a1cfd, caused by buildinfo not properly escaping quotes.

Rely on CMake to escaping strings instead using configure_file().

Fix uninitialized value

Own mistake in rB74188e65028d268af887ab2140e4253087410c1e

Fix compilation error in GHOST

ELEM macro isn't available in GHOST library.