Blender Git Loki

Fix crash in delaunay C interface test.

The test forgot to set the new need_ids field, which luckily
exposed a bug in the C api for delaunay when that field is false.
Fixed the bug and the test, and added a test for the need_ids false
case.

Pose backup: convert from C to C++

Convert `pose_backup.c` (in C) to `pose_backup.cc` (in C++). This will
make future improvements easier. For now, it's the same code with just
some additional explicit casts (C++ doesn't allow implicitly casting
`void *`), `NULL` changed into `nullptr`, and some other simple changes.

No functional changes.

Fix T89881: ignore unavailable sockets when searching for link cycles

Cleanup: correct the comment in ghost

The same comments were written in clientToScreen and screenToClient in
GHOST. I corrected them.

Ref D11986

Fix API doc generation after recent context additions

Cleanup: Remove unused function

LineArt: UI cleanups.

Wording on the UI, slider consistency and material mask switches layout.

Reviewed By: Sebastian Parborg (zeddb)

Differential Revision: https://developer.blender.org/D11839

Fix bug in assert in delaunay test.

Assert was trying to say x coords of arcs lined up, and didn't do that.

Speedup rigid body "Copy from Active" operator

If there were lots of selected objects without an existing rigid body,
we would add rigid bodies to them one by one.

This would be slow in python, now we instead do this as a batch
operation in C.

On my (Intel) MacBook it used to take 60 seconds and with this change it
takes about 0.3 seconds.

Reviewed By: Sebastian Parborg

Differential Revision: https://developer.blender.org/D11957

Cleanup: Getters for asset-handle data

While the asset-handle design is supposed to be temporary (see
35affaa971cf), I prefer keeping the fact that it's nothing but a file
entry pointer an implementation detail that is abstracted away. So this
introduces getters for the file data we typically access for
asset-handles.

Fix T89981: missing refresh on the compositors render layer node when adding/removing AOVs

Just refresh the node's outputs via ntreeCompositUpdateRLayers().

Maniphest Tasks: T89981

Differential Revision: https://developer.blender.org/D11973

Cleanup: Store asset-handle in drag data

Would previously pass a few properties that are available via the
asset-handle now. This asset-handle is also required for some of the
asset API, e.g. the temporary ID loading. This will probably be needed
before too long.

Cleanup: added const keyword to BLI_dlrbTree search functions.

Fix T89979: Assert in edit mode with curve to mesh node

The node tagged polys normals dirty, but the function to calculate the
normals didn't clear the dirty flags for polys. Now clear the poly and
corner dirty normal flags.

Cleanup: Correct asset TODO comment, move setter next to getter

Fix T89687: Curve to mesh node incorrect face orientation

The new faces should have a winding direction that points them outward,
the fix was swapping the order of each face's edge and vertex indices.

Cleanup: Move asset-handle functions to own file

Keeps files minimal and focused. I much prefer that over having all
kinds of stuff in general files like `asset_edit.cc`.

Cleanup: Use const arguments and less sequential iteration

Using const indexes and offsets helps to make the logic less sequential,
which is hopefully easier to understand and possibly easier to parallelize
in the future. Also order return arguments last.

Cleanup Preview rendering: Separate world preparation.

Small cleanup that moves world preparation out of scene preparation.

Cleanup: fix clang-tidy warning readability-qualified-auto

No functional changes.