Blender Git Commits

Cleanup: clang-tidy utfconv

Cleanup: use doxygen sections in py_capi_rna.c

Cleanup: Better names for eDRWColorManagement.

Names describe better what will be applied. Previous names were
extracted from the original code, that weren't accurately named.

Cleanup: Use nullptr.

Cleanup: use "pyrna_enum_*" prefix for RNA utility functions

Cleanup: move RNA utility functions into a generic module

Avoid having to include bpy_rna.h for enum utility functions,
recently added to idprop_py_ui_api.c.

BLI_string: return string length from BLI_string_flip_side_name

Useful for callers that need the string length.

Fix errors pasting flipped names in the action editor

Use BLI_str_quoted_substr_range instead of in-line
quote extraction to resolve:

- Bone names containing quotes caused flip to fail.
- Missing NULL check if a matching quote could not be found.

BLI_string: add BLI_str_quoted_substr_range

This is a similar funciton to BLI_str_quoted_substrN
that extracts the range of the quoted string
instead of allocating a new string un-escaped string.

Cleanup: remove redundant strstr calls

Rely on BLI_str_quoted_substrN to detect if the prefix exists since
this function exists early there is no need to check before calling.

Fix: Incorrect versioning for float IDProperty UI data

The code put the value from the "min" property into the "max"
value. This would have crashed if min was null and max wasn't.

Fix T91088: Assigning custom property value in python resets UI data

Assigning a new value to an IDProperty with the Python API would free
the entire contents of the existing property, which unfortunately
happened to include the UI data. The fix is to extract the UI data from
the existing property before freeing its contents. An alternative
would be adding another argument to `IDP_FreePropertyContent_ex`, but
this solution is clearer and doesn't increase complexity elsewhere.

Fix T91084: Missing versioning for object pose bone property UI data

Objects also have a list of "bone" pose channels embedded directly.
These properties are user visible, so their UI data should be versioned.

Cleanup: Reduce variable scope

Fix: Output int for precision in UI data as_dict method

This is stored internally and used as an integer, so there is no need
to convert it to a float for "as_dict". This was just an oversight.

Cleanup: pass value by ref in draw_color_management

Fix T88433: no greaspencil depsgraph evaluation with certain drivers

When the same stroke was used as a driver variable, this could make this
stroke already tagged as built in the course of building driver
variables (via `build_gpencil`), but then important stuff from
`build_object_data_geometry_datablock` could be missed later on (because
both of these funtions use `checkIsBuiltAndTag`). Most importantly,
setting up operations such as GEOMETRY_EVAL would be skipped entirely.

`build_object_data_geometry_datablock` seems to cover greasepencil just
fine (does the same as `build_gpencil` and more). Proposed solution is to
remove `build_gpencil` entirely. In `build_id` it would then also call
`build_object_data_geometry_datablock` for `ID_GD` IDs. Now the covered
types that _call_ `build_object_data_geometry_datablock` match exactly
to what is covered _inside_ `build_object_data_geometry_datablock`.

Think this "duplication" of functionality was just overseen in
rB66da2f537ae8 [`build_gpencil` existed long before and said commit made
greasepencil a real object with geometry and such].

thx @JacquesLucke for additional input!

Maniphest Tasks: T88433

Differential Revision: https://developer.blender.org/D12324

Fix T90989: Annotation opacity must not be animatable

All props of annotations are not animatable by design and opacity must be equal.

As the opacity is reused by gpencil objects, a new prop has been created in order to use different props for annotations and GP objects.

Cleanup: DRW color management seperated in multiple functions.

Cleanup: Moved DRW_vieport_colormanagement_set to draw_color_management.