Blender Git Commits

Merge branch 'blender-v2.91-release'

Fix add-object cursor plane failing to update on zoom

Zoom with an orthographic view wasn't refreshing the preview plane.

Add Object Tool: support placing objects in orthographic axis views

When an projecting onto a plane that is orthogonal to the views Z axis,
project onto a view aligned axis then map it back to the original plane.
see: ED_view3d_win_to_3d_on_plane_with_fallback

Since the depth can't be properly visualized in 3D, display a 2D so
it's possible to to tell the depth from the cursor motion.

Add Object Tool: use the closest view-aligned axis as a fallback

When using surface orientation and nothing is under the mouse-cursor,
pick the axis that's closest to the view's Z axis.

Now by default default, drawing into empty spaces wont use a plane
orthogonal to the view.

UI: Fix panel drag icon added to redo panel

Error in cleanup commit 0d93bd8d639. Currently floating panels
cannot be dragged, so the widget should not be displayed.

Cleanup: use a struct to backup/restore values for offscreen drawing

Variables to temporarily override values was scattered,
making it harder to follow.

Fix add-object tools cursor distorted drawing on save

Generating the thumbnail left the view matrices set to values
that couldn't be used for cursor drawing.

Backup/restore the matrices for off-screen drawing.

Cleanup: remove unused perspective argument to off-screen drawing

Some callers were passing in dummy values, this can be accessed from
`RegionView3D.is_persp` can be used to check this.

Cleanup: rename do_sky argument to draw_background

This was leftover from Blender internal, follow the naming
already used by the draw manager.

Cleanup: remove unused off-screen drawing struct

Cleanup: spelling

Cleanup: clang-format

Cycles: Fixed zero sized normals when certain attributes were missing.

The Normal Map node was falling back to (0, 0, 0) when it was missing
the required attributes to calculate a new normal.
(0, 0, 0) is not a valid normal and can lead to NaNs when it is
normalized later in the shader. Instead, we now return sd->N,
the unperturbed surface normal.

Fix T82769: remove thread local data from PTCacheMem

The issue was that the same point cache was read by multiple
threads at the same time (the same object was evaluated for
render and for the viewport).
Both threads incremented PTCacheMem->cur which lead to the crash.

The fix is to remove the PTCacheMem->cur and store it on the
stack instead. This way every thread has its own cur.

Reviewers: brecht

Differential Revision: https://developer.blender.org/D9606

Atomic: Cover with unit tests

Cover all atomic functions with unit tests.

The tests are quite simple, nothing special so far. The goal is to:

- Make sure implementation exists.
- Implementation behaves the same way on all platforms
(We had issue when MSVC and GCC were behaving differently in the
past).
- Proper bitness is used for implementation and non-fixed-size
function implementation.

The tests can be extended further to make sure, for example, that
CAS operations do not cast arguments to a more narrow type for
comparison. Considering it a possible further improvement, as it is
better be done being focused on that specific task.

There is an annoying ifdef around 64bit implementation, which uses
same internal ifdef as the header does. This check is aimed to be
removed, so is easier to simply accept such duplication for now.

The tests seems somewhat duplicate for signed/unsigned variants and
things like this. The reason for that is to keep test code as simple
as possible: attempting to do something smart/tricky in the test code
often causes the test code to be a subject of being covered with its
own unit tests.

Differential Revision: https://developer.blender.org/D9590

Fix RNA not giving error with invalid identifiers for collection properties

Guarded allocator: Add explicit switch to the lockfree implementation

Previously the only way to use lockfree implementation was to start
executable and never switch to guarded allocator.

Surely, it is not possible to switch implementation once any allocation
did happen, but some tests are desired to test lock-free implementation
of the allocator. Those tests did not operate properly because the main
entry point of tests are forcing guarded allocator to help catching
bugs.

This change makes it possible for those tests to ensure they do operate
on lock-free implementation.

There is no functional changes here, preparing boilerplate for an
upcoming work on the allocator tests themselves.

Guarded allocator: Add safety around type change

While it might not cover all possible abuse of API, it does provide
basic checks against most obvious usage mistakes.

Guarded allocator: Fix lock-free allocator tests

Previously the lock-free tests were actually testing guarded allocator
because the main entry point of tests was switching allocator to the
guarded one.

There seems to be no allocations happening between the initialization
sequence and the fixture's SetUp(), so easiest seems to be just to
switch to lockfree implementation in the fixture's SetUp().

The test are passing locally, so the "should work" has high chance
of actually being truth :)

Differential Revision: https://developer.blender.org/D9584

Fix lost node links when linked node group datablock is temporarily missing

Don't refresh the list of sockets, so that when the .blend file is restored the
links remain valid. Also display such nodes in red to indicate an error, same
as when the node type info is missing.