Blender Git Loki

Fix T85752: Collection Instance Crash when instancing collections with disabled subcollections

Root of the issue was actually hidden deep in depsgraph itself: it would
not properly update all of its COW IDs using a datablock when depsgraph
decides to evaluate or un-evaluate it.

This would lead to evaluated IDs pointing to either:
- orig IDs when there was an evaluated version of those (annoying bug,
but not a crashing one).
- old address of previously evaluated IDs that no longer exists in the
depsgraph (causing the crash from the report e.g.).

This commit adds an extra step at the end of nodes building, that goes
over all of already existing IDs in the depsgraph to check whether they
do one of the two things above, and tag them for COW update if so.

NOTE: This only affects depsgraph (re-)building, not its evaluation.
This remains consistent with the fact that operations that may change
the depsgraph content (like Collection exclusion etc.) need to trigger a
rebuild.

NOTE: Performances: Worst case scenarii, like (un-)excluding a whole
character collection in a production file, lead to 5% to 10% extra
processing time in depsgraph building. Most of it comming from extra COW
processing (in depsgraph's update in `build_step_finalize`), the detection
loop itself only accounts for 1% to 2% of the whole building time.

Maniphest Tasks: T85752

Differential Revision: https://developer.blender.org/D10907

Merge branch 'master' into cycles-x

Merge branch 'master' into temp-attributes-panel

Cleanup: Use named unused arguments in Cycles Device

Geometry Nodes: new Material Replace node

This node can change all faces that use a specific material to use a
different material. Using this node is significantly more efficient
than creating a selection from all faces with a specific material
index and then using the Material Assign node.

Ref T88055.

Differential Revision: https://developer.blender.org/D11325

Merge branch 'master' of https://git.blender.org/blender

Depsgraph: remove mesh edit-mode pointer duplication

Share the pointer with the original mesh instead, this matches behavior
of all other objects edit-mode data.

Duplicating the edit-mesh pointer makes updates to edit-mesh require
a COPY_ON_WRITE update, which is currently an expensive operation
(copying the entire mesh).

Notes:

- This change is from 802027f3f8f9a83a77134a2b104a25ff3a4ac013
so the edit-meshes object pointer `BMEditMesh.ob` referenced the COW
version of the object. This pointer has since been removed, so the
copy is no longer needed.

- Having a separate edit-mesh pointer could be used so linked duplicates
could have their own generated meshes. For this to be supported,
many other changes would be needed: see D10920.

Fix T88227: Eevee not working on AMD 535 cards.

Enabled HQ normals workaround for this specific configuration.

Fix T88190: Freed memory use when iterating over id-properties

The id-property iterator referenced a PyObject pointer without
increasing it's user count - allowing for errors if the value
goes out of scope during iteration.

Fix memory leak in Python IDproperty iterator

Looping over IDProperty keys or calling iteritems leaked memory.

Error in original Python idproperty support from
8768707610fbc1cea2bde069cdfd6d3f3e2fc522

Fix T88180: Enable HQ normal workaround for RX 580X cards.

This needs to be backported to 2.83.

Fix T88145: Dynamic Paint initial color using vertex color not working as expected

Mistake in {rBe48c4d73d378}.

Was using the vertex index as a lookup for the loop color (instead of
the loop index).
(Issue was not present in original D1429 btw).

Maniphest Tasks: T88145

Differential Revision: https://developer.blender.org/D11212

Version bump 2.83.16 rc.

Fix T88227: Eevee not working on AMD 535 cards.

Enabled HQ normals workaround for this specific configuration.

Cleanup: quiet -Warray-parameter warnings from GCC11

Some warnings remain that require larger changes.

Transform: use ID_RECALC_GEOMETRY flag when updating object data

While this doesn't provide any noticeable benefits at the moment,
it allows for geometry updates skipping copy-on-write in edit-mode
in the future.

Cleanup: conversion warning

Fix T88227: Eevee not working on AMD 535 cards.

Enabled HQ normals workaround for this specific configuration.

Eevee Wavelength Node Support

This patch adds wavelength node support to Eevee, similar to how
Eevee Blackbody node works, thus it is a little off from Cycles.

Reviewed By: #eevee_viewport, fclem, brecht
Differential Revision: https://developer.blender.org/D11326

tmp