Blender Git Loki

Fix T67358: Compositor Disabled Node Config -> SegFault

The issue was caused by wrong conversion happening after some of the
proxies are removed. Easiest solution is to first remove proxies and
then add required converter operations.

Thanks Jeroen for the review!

Fix T77460: Easy to create cyclic dependencies in collections and crash Blender.

Cyclic check was not checking for collections instanciated by objects...

Fix crash when opening some old/broken .blend files after recent fix.

Now that `BKE_main_collections_parent_relations_rebuild()` is called
from readfile code, we need to make it resilient to potential NULL
master collection pointer in scenes.

Fix (unreported) critical mistake in Collection liblink code in readfile.c.

Prelimenary step to fix T77460.

Not sure how or when that thing was done, but since that call walks
around collections relationships, it's an utterly critical violation of
liblinking principles (code here should never, ever 'get outside' of its
own ID scope).

This was wroking so far only because code called through this function
(`BKE_collection_parent_relations_rebuild`) was only following parents
pointers (in `BKE_collection_find_cycle()`), which would be either valid
or non-existent.

But next commit is going to change that to also check collection's
objects instancing of other collections.

Fix T78172: Undo crash due to IDTemplate operations missing undo push.

This should be included in 2.83 as well.

Bumped version o blender v2.83.2-beta

Revert "Fix T77460: Easy to create cyclic dependencies in collections and crash Blender."

This reverts commit 293b00beb5df27b4455de743fd0684f0988153b0.

Revert "Fix (unreported) critical mistake in Collection liblink code in readfile.c."

This reverts commit 517f32045c282f1031299268ad0ebfa8f934bd1a.

Fix T77774: New undo code broken by 'make local' behavior.

This is actually a nice issue due to too much optimization...
* Making an ID local just reuse the linked one whenever possible, instead of
actually making a copy of it.
* Therefore, the collection containing that ID is seen as unchanged, since
the pointer itself remained the same.
* But on undo step, there is no way to reuse that local object, which then
gets deleted, and linked one gets re-created - at a different address.
* Collection, however, since unchanged, is not updated at all and thus keeps
reference to the to-be-deleted local object, instead of the linked one.
* Issue gets even worse with viewlayers, this leads to the crash.

To address this, this patch adds a 'virtual' update flags that does nothing
in update case, but will ensure that the affected IDs using the one made local
are properly detected as changed across the relevant undo step.

Note that the recalc flags were chosen mostly for a logical reason, and also
because they are already properly dealt with and cleared by undo code,
so this looks like the optimal solution.

Note: slightly ammended for 2.83, change should not have any effect in
practice.

Reviewed By: brecht

Maniphest Tasks: T77774

Differential Revision: https://developer.blender.org/D8006

Revert "Fix T77774: New undo code broken by 'make local' behavior."

This reverts commit 554ed613ae5f26b205f65ed950ae50baf9f009b5.

Fix T66786: Audio SDL: Video editor Sound muted without muting it

Porting fix for SDL 2 audio formats from audaspace upstream.

Fix T77803: IK Degrees of freedom drawing glitch

Forgot to update the lineOutput what resulted in that the sphere was not
rendered on all platforms.

Reviewed By: Cl�ment Foucault

Differential Revision: https://developer.blender.org/D8098

Fix T77803: IK Degrees of freedom drawing glitch

IK degrees of freedom is rendered using wires and a solid sphere. The
solid used the wireframe drawing what resulted into drawing glitches.
This patch adds a new shader to draw the solid shape.

Reviewed By: Cl�ment Foucault

Differential Revision: https://developer.blender.org/D8044

Fix (unreported) wrong size of UserPreferences' `dupflag` parameter.

Adding volume obdata option to `eDupli_ID_Flags` enum made it go beyond
the 16 bits of a short... Also, enums should typically be stored in
unsigned integers.

Fix T77915: Cycles OSL microfacet closure not working in custom shaders

The code to implement the newer closure in terms of the old one got lost in
the removal of our stdosl.h copy. Now implement it as a builtin closure.

Cycles: Refactor microfacet BSDFs to remove separate anisotropy code

Since the sampling and evaluation functions handle both cases anyways,
there's not really a point for keeping the distinction in the kernel,
so we might as well cut down the number of CLOSURE_BSDF_MICROFACETs a bit.

Differential Revision: https://developer.blender.org/D7736

GPencil: Fix unreported Vertex Opacity Overlay not working

This values was not working because was removed by error in refactor.

Reviewed By: mendio, fclem

Differential Revision: https://developer.blender.org/D8061

Fix T75414: Incorrect masking in Color Balance modifier

Color balance factor was infinity. Clamp to +/- `FLT_MAX`

Reviewed By: sergey

Differential Revision: https://developer.blender.org/D7884

Fix T76767: Cycles performance regression with CLI renders

When picking a small tile size when doing a CLI render will
yield many status updates being printed to the console
causing a slowdown in the render process. 2.79 with the
same amount of tiles did not have this slowdown.

The reason for this turned out to be a debugging aid added
in rBd2757d149bf2 which disabled buffering for stdout which
on windows caused every single character being printed to the
console to try to obtain a mutex, and worse the thread being
put to sleep when this mutex was unavailable leading to poor
performance.

This patch changes the behaviour by only disabling the
buffering in debug builds.

CLI render of the default cube with 16x16 tiles at 1080p

2.83 : 37.57s
now : 17.03s

note: this only affected CLI renders, renders from the UI
do not report this kind of information and had no such
slowdown.

Fix T77460: Easy to create cyclic dependencies in collections and crash Blender.

Cyclic check was not checking for collections instanciated by objects...