Blender Git Commit Log

MSVC: Fix macro collision with MSVC Headers

Picked up while investigating a build error on the functions branch
which seems to use this specific header in a way master doesn't.

The problem:

The MSVC headers define a `_CONCAT` macro, so does BLI_kdtree_imp.h
however at the end `BLI_kdtree_imp.h` undefines the macro making the
MS headers that still rely on it "unhappy".

Who's fault is this:

Ours, C99 Spec says

```
7.1.3 Reserved identifiers

- All identifiers that begin with an underscore and either an uppercase letter or another underscore are always reserved for any use.

...

if the program removes (with #undef) any macro definition of an identifier in the first
group listed above, the behavior is undefined.
```

So we should not have defined it, and we definitely should not
have undefined it.

We have *tons* of these violations, although fixing them would be great
at one point lots of them are in /extern or in the 3rd party deps,
I'd rather deal with them on a case by case basis when it actually
causes issues.

Differential Revision: https://developer.blender.org/D5790

Reviewers: campbellbarton, JacquesLucke

Quiet self assignment warning

VSE: quiet missing prototype warnings

UI: quiet warning when drawing markers

The compiler was warning that it assumed that
crfa - 4 < cfra is always true even though that might not
be the case due to overflow. This patch just removes
the condition that caused the assumption.

BLI: make Map.add_or_modify more powerful

The function now allows custom return types defined
by the callbacks. This can be useful when a user of the
data structure has to implement some custom behavior.

BLI: add utility to print VectorSet stats

BLI: speedup adding to VectorSet by removing a check

BLI: remove non const accessors in VectorSet

With this the values could have been changed without
updating the hash table.

fixes after merge

Merge branch 'master' into functions

BLI: add missing include

Merge branch 'master' into functions

BLI: rename SetVector to VectorSet

The structure is a set built on top of a vector and not the other
way around.

BLI: Improve forwarding semantics of some data structures

This makes it possible to use e.g. `std::unique_ptr` in a map.

Merge branch 'master' into temp-npr-gpencil-modifiers

Merge branch 'master' into temp-lanpr-cleanup

Cleanup: make format.

Gpencil: modifier RNA fixes.
For multiply and length modifiers.

Gpencil: BKE functions for stroke length & splitting.

Gpencil: npr related modifier files added.
Including length modifier and multiply modifier.