Blender Git Commit Log

Fix: Incorrect loop edge index

Also some cleanup

Nodes: Add Compare node operations to link drag search menu

Exposes compare operations via rna emums.
This uses the rna enum to build the search list using
named operations linked to socket A.
This also weights the Math Node comparison operations lower
for geometry node trees.

Differential Revision: https://developer.blender.org/D13695

Fix face orientation in face mode

Merge branch 'master' into temp-geometry-nodes-extrude-mesh

Cleanup: Use IndexRange [] operator

LineArt: Correct collection intersection mask logic.

The logic used to be:

"if collection doesn't have child collection, check if ob is from this one"

The correct logic should be:

"if collection child does not have this ob, then check this collection".

LineArt: Correct collection intersection mask logic.

The logic used to be:

"if collection doesn't have child collection, check if ob is from this one"

The correct logic should be:

"if collection child does not have this ob, then check this collection".

Merge branch 'master' into temp-lineart-contained

LineArt: Correct clamping of out of bound isect index

Handles rare cases where line doesn't intersect the triangle correctly.

Fix T94464: video texture is not refreshing

In the past that worked because the `GPUMaterial` referenced the
`ImageUser` from the image node. However, that design was incompatible
with the recent node tree update refactor (rB7e712b2d6a0d257d272e).
Also, in general it is a bad idea to have references between data that is
owned by two different data blocks.

This incompatibility was resolved by copying the image user from the node
to the `GPUMaterial` (rB28df0107d4a8). Unfortunately, eevee depended
on this reference, because the image user on the node was update when the
frame changed. Because the image user was copied, the image user in the
`GPUMaterial` did not receive the frame update anymore.

This frame update is added back by this commit. The main change is that
the image user iterator now also iterates over image users in `GPUMaterial`s
on material and world data blocks. An issue is that these materials don't
exist on the original data blocks and that caused the check in
`build_animation_images` in the depsgraph to give the wrong answer.
Therefore the check is extended.

Right now the check is not optimal, because it results in more depsgraph
nodes than are necessary. This can be improved when it becomes cheaper
to check if a node tree contains any references to a video texture.
The node tree update refactor mentioned before makes it much easier
to construct this kind of run-time data from the bottom up, instead of
scanning the entire node tree recursively every time some information
is needed.

Cleanup: Silence warning for wrong const char comparison

Incorrectly used comparison for empty string.

Reported in chat by @jacqueslucke.

Fix T94416: incorrect handling when nodes are linked in a loop

This just skips the entire algorithm when there are cycles.
In the future, cycles could be handled more gracefully in the
algorithm, but for now that's not worth it and is not necessary
to fix the bug.

Nodes: Weight drag link search for Math nodes

As @hooglyboogly suggested in D13680, this patch adds weighting
to the search results. Dragging from a vector/rgba socket weights
the Vector Math node higher than a float Math node, and vice versa.

Reviewed By: HooglyBoogly

Differential Revision: https://developer.blender.org/D13691

Fix (unreported): remove menu separators from drag link search

Search was picking up the menu separator entries.
Add check for these which are defined by empty identifier strings.

Cleanup: Variable naming

Cleanup: Simplify face mode based on edge mode cleanup

Cleanup: Use more consistent naming, further simplifications

Cleanup: Simplify face corner calculations

Cleanup, use IndexRange, slice, add comments

Fix build error