Blender Git Commits

Experimental Features: Sanitize missing (latest) options

There was an oversight when adding new experimental user preferences.
I can try to overengineer this later to make it more fail-proof. But for now
it should be clear what to update when adding a new variable.

Experimental Features: Rename Image editor option

This prevents having multiple UI strings starting exactly the same:
* Legacy A...
* Legacy B ...

CleanUp: Remove header only definition

node_draw_link_straight existed in header files without a body

Cleanup: reduce variable scopes

Cleanup: remove redundant theme versioning

All themes older than 2.8x are initialized from the defaults,
there is no need to version them.

Cleanup: spelling

Also correct own correction from 58b8724a4892
thanks @mont29 for raising this.

Fix userpref.blend using version from startup.blend

Version patching userpref.blend wasn't using the correct version,
causing settings not to be properly updated.

This seems the likely cause of T70196 and similar bugs.

License: Rename GPL2 license to match the name specified in copyright.txt

The license was renamed GPL-license.txt => license/GPL-2.0txt in 0434efa09ddc451.

Although the renaming made all the license files consistent, we are better off
not updating the copyright file in Blender. Instead we can live with some mild
inconsistency in the license names.

Fix (unreported) assert in texture code when loading some old 2.74 blend file.

Trying to open the 2.74 Fishy Cat file would generate endless asserts in
customdata code. This commit refactors and cleans up the code of
`psys_get_dupli_texture` to avoid useless calls and data access, and
validate data before trying to further access it.

No behavioral changes expected here (besides getting rid of the assert).

Cleanup: readfile for workspaces: NULLify non-owned data pointers.

`workspace_hook` of wmWindows store pointers for runtime data and to
data belonging to other IDs (workspace's layouts). That kind of pointers
should always be cleaned up on read, it allows for cleaner segfault
crash in case of mistakes in code updating/re-setting them, and avoids
potential security issue of accessing random memory address.

No behavioral change expected here.

Fix (unreported) design flow in how workspace's relation data are read from .blend file.

Relying on pointer addresses across different data-blocks is extremely
not recommended (and should be strictly forbidden ideally), in
particular in direct_link step of blend file reading.
- It assumes a specific order in reading of data, which is not ensured
in future, and is in any case a very bad, non explicit, hidden
dependency on behaviors of other parts of the codebase.
- It is intrinsically unsafe (as in, it makes writing bad code and making
mistakes easy, see e.g. fix in rB84b3f6e049b35f9).
- It makes advanced handling of data-blocks harder (thinking about
partial undo code e.g., even though in this specific case it was not
an issue as we do not re-read neither windowmanagers nor worspaces
during undo).

New code uses windows' `winid` instead as 'anchor' to find again proper
workspace hook in windows at read time.

As a bonus, it will also cleanup the list of relations from any invalid
ones (afaict it was never done previously).

Differential Revision: https://developer.blender.org/D9073

CleanUp: snode_group_offset -> space_node_group_offset

CleanUp: Renamed drawnodespace -> node_draw_space

Fix text editor auto-complete refinement feature

Left/right arrow keys can refine the completion,
this wasn't redrawing and there was an off-by-one error checking
the next character.

Fix text editor auto-complete mouse interaction

- Remove MMB for activating an auto-complete item (use LMB instead).
- Update on cursor motion.

Fix invalid version check in 'project_source_info'

Own error in 870fcb3857ba36986d1d44ab4ac519897f8fb264

Cleanup: use raw-strings for regex in console completion

Cleanup: pep8 (indentation, spacing, long lines)

Cleanup: pep8, blank lines

Cleanup: trailing space