Blender Git Commits

Windows: Clean-up warnings originating from bullet

Bullet currently generates the majority of the warnings
on windows all of them are silly. This patch disables
all warns from bullet for now.

We should revisit this if/when we update bullet
to a newer version.

Reviewed By: sergey brecht

Differential Revision: https://developer.blender.org/D7118

Windows: Cleanup warning about non returning dtor

`google::LogMessageFatal::~LogMessageFatal` calls `abort`
which MSVC correctly identifies as 'not returning'
and warns about a potential memory leak.

Given this is intended behaviour and glog is not overly
concerned with shutting down the process nicely, we
can safely ignore this warning.

Fix T73626: crash scrubbing timeline with Cycles viewport and smoke/fire

Cleanup: refactor image loading to use abstract ImageLoader base class

Rather than passing around void pointers, various Blender image sources now
subclass this. OIIO is also just another type of image loader.

Also fixes T67718: Cycles viewport render crash editing point density settings

Cleanup: add ImageHandle to centralize image ownership logic

Cycles: add internal default volume shader, to be used for new volume object

This is mostly straightforward, but required some refactoring to ensure that
the default volume material does not always turn on the volume feature for GPU
rendering.

Cleanup: remove foreach include from header, conflicts with OpenVDB

Fix Optix build error on Linux with some compilers

Cleanup: Fix build warning on windows.

printf is called for a size_t (64 bit on x64) type
but the formatter is `%lu` (32 bit) leading to a
warning with MSVC.

`%zu` is the appropriate formatter.

EEVEE: Fix test crashing

Probe counting now needs to have proper gl capabilities initialised to run
correctly.

Cleanup: Fix unused debug var warning.

GPencil: Change default hardeness for Airbrush

Depsgraph: Fix crash deleting Viewer image from Outliner

Was happening when having compositor open with Viewer node attached
directly to Render Layers output.

There were two things involved here:

1. The code which was storing CoW-ed versions of IDs was checking all
IDs for whether they are expanded or not. This was causing access
of freed memory for deleted IDs which do not need CoW (such as IM).

Simple fix: store ID type as a scalar and use early check before
doing more elaborate check based on accessing fields of id_cow.

2. The code which was ensuring view layer pointer is doing CoW for
scene. This isn't an issue on its own, but scene might have an
embedded ID such as compositor which was actually traversed by the
ID remap routines. This was causing remapping procedure to go into
non-updated copy of compositor, accessing freed Viewer image ID.

Solved by not recursing into embedded IDs for datablocks as those
are supposed to have own copy-on-write operations which takes care
of re-mapping.

Reported my Bastien, and also pair-coded with him.

Fix Cycles crash in BVH8 build due to out of bounds memory access

Differential Revision: https://developer.blender.org/D7114

Windows: Clean-up linker warnings regarding MSVCRT.lib

For debug builds we link the against the release mode libs
for C based libraries, which are technically linked against
a different CRT, which the linker will implicitly try to link.

Which results in a linker warning about mixing the debug/release CRT.

This patch prevents the implicit linking of the release
CRT in debug configurations for sub projects that had issues
with it.

Cleanup: Typo in comments.

LibQuery: Add option to NOT process embedded IDs.

Request from depsgraph department, which does basically consider those
embedded IDs as any other data-block (unlike any BKE ID management code).

EEVEE: Replace octahedron reflection probe by cubemap array

We implement cubemap array support for EEVEE's lightcache reflection probes.
This removes stretched texels and bottom hemisphere seams artifacts caused
by the octahedral projection previously used.

This introduce versioning code for the lightcache which will discard any
lightcache version that is not compatible.

Differential Revision: https://developer.blender.org/D7066

Workbench Simplification Refactor

This patch is (almost) a complete rewrite of workbench engine.
The features remain unchanged but the code quality is greatly improved.
Hair shading is brighter but also more correct.

This also introduce the concept of `DRWShaderLibrary` to make a simple
include system inside the GLSL files.

Differential Revision: https://developer.blender.org/D7060

Cleanup: stop encoding image data type in slot index

This is legacy code from when we had a fixed number of textures.