Blender Git Commits

Fix (unreported) critical mistake in Node copying code.

Nice reversed-logic mistake in rB693721cc7e7d.

How this could remain unnoticed for almost one year is fairly
mysterious, this should have basically broke all node tree copying,
would expect such bug to get reported within days, weeks at most...
Probably because that function is not that much used in current code.

Nice reminder also that those bloody nodetrees still need a lot of
cleanup/refactor/simplification when it comes to ID management code.

Reported/fixed as part of D6484, but this really needs its own commit.

Edit Mesh: Use multithreading in other parts of Auto Merge & Split

In the Auto Merge & Split feature, multithreading was only used to
find duplicates between vertex and another vertex.

But with this patch, multithreading is now used to find intersections
etween edge and edge and between edge and vertex.

In my tests I noticed a performance improvement of around 180%
(0.017151 secs to 0.009373 secs)

Differential Revision: https://developer.blender.org/D6528

Industry Compat keymap: Fix Polybuild tool not working with this keymap

I ended up simply removing the gizmo entries here - they seem to be no longer needed.

Fix T72682: Regression when moving markers while holding ctrl

In 2.79 when moving a marker with `G` while holding `ctrl` the marker
would snap to one-second movements. This was (probably accidentally)
removed when the Timeline Editor was removed in rB5374865523faf253.

Reviewers: mano-wii

Differential Revision: https://developer.blender.org/D6527

Fix T72423: Incorrect tooltips in curve profile layout

Industry Compat keymap: Properly support Grease Pencil Edit Mode

Many things weren't working correctly in GP Edit Mode, such as select/deselect/invert all, basic tools, extrude, snap etc.

Now this mode works consistently with other modes.

GPencil: Add missing update in previous commit of task T72897

CMake: enable FFTW for headless & bpy configurations

This caused the ocean modifier to be disabled.

Cleanup: warning

Fix T72897: Move Channels operator moves Grease Pencil Layers wrongly

This operator was pending of fix.

BLI_kdopbvh: Deduplicate code

No need to create different callbacks for `BLI_task_parallel_range`,
these callbacks are called a few times.

Industry Compat keymap: Support the recently added Drag option

This also simplifies the keymap a lot, since I can now remove a lot of hacky exceptions to make box select work with the gizmo-tools.

Industry Compat keymap: Support 1-3 keys in the UV Editor when Sync Selection is enabled

This also makes it possible to hold Shift to enable multiple selection modes in Edit Mode

BLI_bvhtree_overlap does not work multithreaded

`BLI_task_parallel_range` counts the number of tasks depending on the
number of items.

In the case of `BLI_bvhtree_overlap` the number of items is always
between 2 and 16, which makes it always run in single thread.

So, set the maximum number of items per thread to 1.

In my tests the cloth collision system (which calls that function)
went from 0.80fps to 0.88fps.

Differential Revision: https://developer.blender.org/D6523

BLI_bvhtree_overlap: Don't use BLI_task API when not needed

No functional change.

BLI_bvhtree_overlap: Fix wrong count of child nodes

As you can see, here is testing the "children" of `node1`.
So bvhtree is `tree1`.

This problem has never been observed because usually `tree_type`
of `tree1` equals `tree_type` of `tree2`.

BLI_bvhtree_overlap: Make sure the number of nodes matches the number of threads

Edit Mesh: Multithread support for Auto Merge & Split

Also collapsed edges are no longer used in the overlap test.
This greatly improves peformanse for cases where the distance tested is
relatively large.

BLI_bvhtree_overlap: Improve non-multithreaded usage

Although not using multithreading, the `thread` parameter in the
`BVHTree_OverlapCallback` callback always returned a value between the
"number of threads".

This parameter should always be 0 in such cases.

Also a `BLI_Stack` was created for each "thread" and used.
This small overhead is no longer seen.

Differential Revision: https://developer.blender.org/D6510

Fix T71495: Some Textures with AnimData not visible in Dopesheet

T71495 describes two problems with animation of textures not showing up in
the dope sheet:

1. textures connected to force fields
2. textures of brushes

This patch resolves the first case.

An alternative would be to switch to iteration of dependencies using
`BKE_library_foreach_ID_link()`. This is a good idea to do at some point,
but adding these few lines was considerably easier & safer to do.