June 30, 2021, 07:40 (GMT) |
Fix: VSE indexer seeking not working correctly Because of the added sanity checks in rB14508ef100c9 (D11492), seeking in proxies would not work correctly any more. This is because it wasn't working as intended before, but in most cases this wouldn't be noticeable. However now when the sanity checks are tripped it is very noticeable that something is wrong The indexer tried to use dts values for time stamps when we used pts in our decode functions to get the time positions. This would make it start in the wrong GOP frames when searching. Now that we enforce no crossing of GOP frames when decoding after seek, this would lead to issues. Now we correctly use pts (or dts if pts is not available) and thus we don't have any seeking issues because of time stamp format missmatch. Reviewed By: Richard Antalik Differential Revision: https://developer.blender.org/D11561 |
June 30, 2021, 07:39 (GMT) |
Fix: VSE timecodes being used even when turned off. Reviewed By: Richard Antalik Differential Revision: https://developer.blender.org/D11567 |
June 30, 2021, 07:38 (GMT) |
Fix: Prevent small memory leak in VSE indexer We need to unref the packet to tell ffmpeg it is ok to free it after use. |
June 30, 2021, 07:37 (GMT) |
Fix: Wrong logic for checking if we can reuse decoded frame We should only check if the new pts value lies inside the duration of the current frame. |
June 30, 2021, 07:37 (GMT) |
FFmpeg: Fix seeking not returning the correct frame when not using TC index Fixed the logic for seeking in ffmpeg video files. The main fix is that we now apply a small offset in ffmpeg_get_seek_pos to make sure we don't get the frame in front of the seek position when seeking backward. The rest of the changes is general cleanup and untangling code. Reviewed By: Richard Antalik Differential Revision: https://developer.blender.org/D11492 |
June 30, 2021, 07:34 (GMT) |
Fix T57397: Movies are blurred after sws_scale Images with 4:2:2 and 4:4:4 chroma subsampling were blurred when `SWS_FAST_BILINEAR` interpolation is set for `anim->img_convert_ctx`. Use `SWS_BILINEAR` interpolation for all movies, as performance is not impacted by this change. Reviewed By: sergey Differential Revision: https://developer.blender.org/D11457 |
June 30, 2021, 07:34 (GMT) |
FFmpeg: Update proxy settings Changes in rBce649c73446e, affected established proxy codec preset. Presets were not working and all presets were similar to `veryfast`. Tunes are now working too, so `fastdecode` tune can be used. I have measured little improvement, but I tested this only on 2 machines and I have been informed that `fastdecode` tune does influence decoding performance for some users. Change preset from `slow` to `veryfast` and add tune `fastdecode` Reviewed By: sergey Differential Revision: https://developer.blender.org/D11454 |
June 30, 2021, 07:33 (GMT) |
Fix T88623, T87044: Make encoded videos play correctly in VLC The issue was two fold. We didn't properly: 1. Initialize the codec default values which would lead to VLC complaining because of garbage/wrong codec settings. 2.Calculate the time base for the video. FFmpeg would happily accept this but VLC seems to assume the time base value is at least somewhat correct and couldn't properly display the frames as the internal time base was huge. We are talking about 90k ticks (tbn) for one second of video! This patch initializes all codecs to use their default values and fixes the time base calculation so it follows the guidelines from ffmpeg. Reviewed By: Sergey, Richard Antalik Differential Revision: https://developer.blender.org/D11426 |
June 30, 2021, 07:33 (GMT) |
Make encoded video fps correct with ffmpeg < 4.4 Before the FFmpeg commit: github.com/FFmpeg/FFmpeg/commit/1c0885334dda9ee8652e60c586fa2e3674056586 FFmpeg would use deprecated variables to calculate the video fps. We don't use these deprecated variables anymore, so ensure that the duration is correct in ffmpeg versions without this fix. Reviewed By: Sergey, Richard Antalik Differential Revision: https://developer.blender.org/D11417 |
June 30, 2021, 07:32 (GMT) |
Fix T87932: Failure to build movie strip proxy We didn't initialize the scaled proxy frame properly. This would lead to issues in ffmpeg 4.4 as they are more strict that the API is properly used. Now we initialize the size and format of the frame. |
June 30, 2021, 07:32 (GMT) |
Cleanup: Remove deprecated variables and functions calls from our ffmpeg code There need to be more cleanup for ffmpeg 4.5 (ffmpeg master branch). However this now compiles on ffmpeg 4.4 without and deprication warnings. Reviewed By: Sergey, Richard Antalik Differential Revision: https://developer.blender.org/D10338 |
June 30, 2021, 07:28 (GMT) |
Fixed issue in previous commit. During development a test was disabled. Enabling it again. |
June 30, 2021, 07:28 (GMT) |
Fix T89405: Viewport Render Preview glitching (AMD) AMD Drivers didn't report an additional space in the rendered. This made testing for the HQ workaround fail and the issue appeared back on certain cards. This fix will test with surrounding spaces or if the renderer name endswith the given string. If any of these are the case the hq normals workaround will be enabled. |
June 30, 2021, 07:27 (GMT) |
Fix: Crash Requesting GPU_SHADER_GPENCIL_FILL builtin shader. Shader doesn't have any shader code. Requesting the shader would crash blender. Solved by removing the enum_value. |
June 30, 2021, 07:26 (GMT) |
Fix T88808: Set Origin missing from Text object in 2.93 Fix T88808. Caused by {rB5f2c5e5bb8c15bf0d6679351e3482f9c38c00935} object type for `TEXT object` was missing in following check that's why `Set Origin` option was lost from object context menu. Reviewed By: lichtwerk Maniphest Tasks: T88808 Differential Revision: https://developer.blender.org/D11495 |
June 30, 2021, 07:22 (GMT) |
Fix T89004: Undefined Geometry nodes cause a crash when connected to a Group Output node. Patch provided by Jacques Lucke. |
June 30, 2021, 07:19 (GMT) |
June 30, 2021, 07:18 (GMT) |
Fix invalid polygon normal array access building bake data Pre computed normals index wasn't properly aligned. Regression from 2ec00ea0c1be1ace7cd0c7b68e43cc8e87dd07c7. |
June 30, 2021, 07:18 (GMT) |
Fix T89265: Crash when tabbing through num inputs Fix by reverting the part of ec30cf0b742f5181c4de91b474ca01d6a809c593 that assigned `but->editval` in `ui_numedit_begin_set_values`. Causing access freed memory when using tab to switch to a numeric input and then leaving the textbox by clicking outside. This was because `ui_numedit_begin_set_values` shouldn't need to set `but->editval` and overwrite the pointer. This would set a pointer that had previously been freed, causing a `NULL` check to fail later on. Ref D11679 |
June 30, 2021, 07:14 (GMT) |
Fix edit-mesh random select regression in random seed use Fix regression in 9c202281287743494fd7d81a13970053bc8a33b5 that wasn't using the random seed correctly. |
|