Blender Git Commits

Cleanup: don't detect duplicate intersections in Embree

It's unclear why this code was added in the first place, but it seems
unnecessary, it can be restored if we find this breaks something.

The Embree docs mention that the same primitive may be hit multiple times, but
my understanding is that about e.g. curves where both the frontside and backside
may be hit. However those hits would be at different distances.

The context for this change is that we want to add an optimization where we
can immediately update throughput for transparent shadows instead of recording
intersections, and avoid duplicate would require extra work. However there is
an Embree example that does something similar without worrying about duplicate
hits either.

UI: Draw tree-views (e.g. asset catalogs) in a box

Makes things look more appealing visually. Plus it's a way to visually
group the tree rows together, which can be important if there are more
widgets surrounding the tree.

Cleanup: Improve readability & comments in UI tree-view header

Fix errors in 68dc970219ef7a559b48bd1b3e45d033367b4172

Swapped preview/timeline keymap and incorrect center measurement.

Fix handling of overrides during append.

Liboverride references need a special handling during append, since
those pointers should never be made local, nor reampped to newly
localized data. And liboverride references should never be directly made
local either, to ensure their liboverride usages remain pointing to
linked data and not local one.

Issue was reported by the studio, and also probably as part of T91892.

Fix possible use-after-free when cancelling temporary rename button

If a renaming button was removed via `UI_but_active_only_ex()` and that
button was placed using the layout system, the button was still in the
layout.
So far this didn't cause issues, because all cases where the button may
be removed were not using the layout system.

Fix T91064: Cycles low poly meshes having black edges when shade smoothed

Fixes:{T91064}

Caused by {rBcd118c5581f482afc8554ff88b5b6f3b552b1682}

- Applies `ensure_valid_reflection()` to the normal input on all BSDFs for CPU and GPU.
- This doesn't affect hair.
- Removes `ensure_valid_reflection()` from the output of Bump Map and Normal Map nodes for CPU/GPU as it is not needed.
- The fix doesn't touch OSL.

Reviewed By: brecht, leesonw

Maniphest Tasks: T91064

Differential Revision: https://developer.blender.org/D12403

Correct error in 68dc970219ef7a559b48bd1b3e45d033367b4172

Included invalid keyword argument.

Sequencer: improvements to preview selection

- Support toggle/deselect/deselect_all options
(matching 3D viewport object selection).
- Support legacy selection behavior.
- Support selecting by the center in preview views (holding Ctrl).

UI: Boolean rename "Self" to "Self Intersection"

Better to be more explicit here, also this matches the recent Boolean Node.

Cleanup: spelling in comments

Fix sequencer sample poll function

Sequencer poll was succeeding outside of a preview region.

This meant it couldn't be used in tool key maps which are currently
shared between preview & sequencer regions.

Sequencer: use pass-through for preview select

Needed for select-drag action as done in the 3D view and UV editor.

Keymap: show sequencer tools in key-map editor

Re-order common sequencer key-map to be at the top level
(shared by preview and sequence view).

Without this sequencer tools would be displayed at different levels
in the hierarchy which is confusing and doesn't represent the separation
between "Sequencer" and "SequencerPreview" key-maps.

Keymap: remove selection from the common sequencer map

Needed for further changes as selection behaves differently
in the preview region.

Keymap: fallback tool support for the sequencer

Note that sample is no longer in the sequencer preview keymap,
it is still accessible as a tool.

This conflicted with click-drag to transform.

UI: rename sequencer "Select" to "Tweak"

This matches the tweak tool elsewhere.

Match names since this name is shown prominently
in the fall back tool selector.

UI: add sequencer preview context menu

This is mostly a place-holder since many items
have not yet been implemented.

Nodes: Composite: Fix wrong socket type for color ramp node

VSE: Reduce memory footprint when using thumbnails

Free strip `anim` data immediately after rendering. This doesn't affect
rendering performance, because each new loop would have to seek to start
of strip. Also strips are now freed anyway, but after rendering loop
ends.

With SF edit file, thumbnail rendering used around 60GB of memory.
Now it uses few hundreds MB (depends on movie file resolution, codec,
etc.)

Freeing of strips caused UI to be unresponsive for brief period. This
issue is not removed, but is more spread out so it is less noticable.