Blender Git Commits

Cleanup: use doxy sections in interface_panels.c

Cleanup: spelling

Fix (unreported): Walk expansion on scene collection

Left walk navigation while the scene collection is active would collapse
the subtree which shouldn't be allowed. This adds another check to
`outliner_item_openclose` to prevent collapsing the scene collection.

Introduced in rBb077de086e14.

Fix: Outliner walk navigation in Data API mode

Because the subtrees in Data API mode are empty for performance reasons,
it was impossible to move through the tree with walk navigation. This
adds an exception to allow walk navigation to expand subtrees in that
mode.

Fix T80159: Custom Normals Averaging crash after clearing
custom split normals data

Clearing custom split normals would get rid of the CD_CUSTOMLOOPNORMAL
layer - but editing data `lnor_spacearr` would be kept.

Adding a CD_CUSTOMLOOPNORMAL layer (if none exists yet) should be done
in `edbm_average_normals_exec` / `BKE_editmesh_lnorspace_update` /
`BM_lnorspace_update` / `BM_lnorspacearr_store`. The thing is that if
the editing data `lnor_spacearr` would still be valid after `Clear
Custom Split Normals Data`, blender would happily call
`BM_lnorspace_rebuild` instead. Doing that without a CD_CUSTOMLOOPNORMAL
layer is asking for trouble.

Now clear lnor_spacearr on `Clear Custom Split Normals Data` as well.

Thx @mont29 for feedback here.

Maniphest Tasks: T80159

Differential Revision: https://developer.blender.org/D8730

UI: Avoid redundant loops in region panel handler

Currently the panel handler loops through every block and every button
for every single panel. This commit moves that check to happen a single
time at the beginning.

Fix T68317: Panel "A" key doesn't collapse subpanels properly

We need to only collapse or expand the first panel under the cursor
rather than all of them. Note that whether the parent panel or
the subpanel is first depends on the order of the uiBlocks in the
region's list.

Clang Tidy: Fix warning

Fix readability-static-definition-in-anonymous-namespace in new code

UI: Cleanup / refactor region panel event handling

The code for handling panel events was much more complicated than it
needed to be. This commit removes some unecessary function calls and
variables, reduces indentation levels by returning early, and does
some other general cleanup.

GPencil: Don't convert color to sRGB

The color is linear, so the conversion is breaking the real color.

Fix T77382: zooming into adjust last operation panel clips contents

This panel should not have zoom functionality at all, just like headers and
many other regions don't have it either.

Cleanup: Move panel category drawing to proper section

Somehow the panel category drawing functions ended up in the middle
of the region event handling code. This commit moves them to their
own section next to the rest of the drawing code.

Cleanup: Fix white space in versions.cmake

Fix Outliner allowing to enter Pose Mode on linked armature

If a different object was active, clicking on a linked armature's pose
in the Outliner would enter Pose Mode for it.
This would actually cause a failed assert, but in release builds the
armature would just enter pose mode.

Steps to reproduce were:
* Link in armature object
* Activate a different object
* In the Outliner, un-collapse the armature object
* Activate Pose Mode by clicking on its pose there

Cleanup: Fix build warning on windows

MSBuild on windows currently spews a warning about
buildinfo.h_fake not being generated.

For build info we use a non existing file to trigger a
custom_command on every build, which has worked well for
years now, however in recent versions of MSBuild it has
started issuing warnings about files that should be
generated but are not.

CMake is actually aware of this being a problem and states
in the documentation that "If the output of the custom command
is not actually created as a file on disk it should be marked
with the SYMBOLIC source file property."

This change fixes the build warning by properly marking the
buildinfo.h_fake as symbolic resolving the warning.

Fix crash of alembic tests after recent depsgraph builder change

Need to make sure node factories are initialized prior to the dependency
graph allocation.

The regression was initially introduced in 5b021dff4136

Thanks Brecht for testing!

Fix: Mantaflow always builds openvdb statically

This would lead to problems when we build a dynamic openvdb library.

Fix: FindEmbree.cmake looking for non existing dynamic libraries and failing

It is now possible to build against a shared embree library.
Before it was only possible to build against static Embree libraries.

Reviewed By: Brecht

Differential Revision: https://developer.blender.org/D8702

Cleanup: clang-format

MSVC: Set proper flags for C++17 support.

MSVC already builds with the /std:c++17 flag but for
'reasons' [1] MSVC still gives the wrong value for the
__cplusplus define.

This change sets an additional cxx flag on supported
compilers to allow the compiler properly identify
C++17 support.

This resolves 2 warnings coming out of bullet about
the register keyword being deprecated.

[1] https://devblogs.microsoft.com/cppblog/msvc-now-correctly-reports-__cplusplus/