Blender Git Commits

Merge branch 'blender-v2.83-release'

Fix sculpt mask interpolation in subdivisions

The interpolation function of the datalayer was misssing so the sculpt
mask data was corrupted every time a subdivision surface modifier was
applied.

Reviewed By: jbakker

Differential Revision: https://developer.blender.org/D7640

Merge branch 'blender-v2.83-release'

Fix T76397: Missing value property on Clear Mask pie menu

Without this value defined it was reusing the same 1.0 value after using
fill mask, so it was not working.

Reviewed By: jbakker

Maniphest Tasks: T76397

Differential Revision: https://developer.blender.org/D7699

Merge remote-tracking branch 'origin/blender-v2.83-release'

Fix: T71040 / T58983 Ocean Modifier crashes at high resolutions

This is not as much a fix as a work around, but given the real
involves replacing how we build fftw, it is not eligible for 2.83
which is in BCON3 already.

The root of the issue lies with (how we build) fftw3

The first issue is: fftw does not build with MSVC, there are other
dependencies that are not compatible with MSVC and for those we
build the libraries required with mingw64, same for fftw

The second issue is: for reasons unknown we really really really
liked all deps to link statically so wherever possible we did so.

Now during the building of the fftw it linked a few symbols from
libgcc (which we do not ship) like __chkstk_ms, for which we passed
some flags to stop generating calls to it. Problem solved! There
is no way this could possibly turn around and bite us in the rear.

fast forward to today mystery crashes that look like a race condition.

What is happening is, we tell the linker that each thread will require
a 2-megabyte stack, now if every thread immediately allocated 2 megs,
that be 'rough' on the memory usage. So, what happens is (for all apps
not just blender), 2 megs are reserved but not backed by any real memory
and the first page is allocated for use by the stack, now as the stack
grows, it will eventually grow out of that first page, and end up in
an area that has not been allocated yet, to deal with that the allocated
page is followed by a guard page, someone touches the guard page it's
time to grow the stack!

Meanwhile in FFTW is it's doing substantial allocation using alloca
(up to 64 kb) on the stack, jumping over the guard page, and ending
up in reserved but not yet committed memory, causing an access violation.

Now if you think, that doesn't sound right! something should have
protected us from that! You are correct! That thing was __chkstk_ms
which we disabled.

Given we do not want a dependency on libgcc while building with MSVC
the proper solution is to build fftw as a shared library which will
statically link any bits and pieces it needs, however that change
is a little bit too big to be doing in BCON3.

So as a work around, we change the size the stack grows from 8k to
68k which gives fftw a little bit more wiggle room to keep it out
of trouble most of the time.

Note this only sidesteps the issue, this may come up again if the
conditions are just right, and a proper solution will need to be
implemented for 2.90.

Fix invalid bit shift when GPU shader attribute is not found

Fix NULL pointer access reported by ASAN (harmless in practice but still weak)

Fix potential crash due to dyntopo GPU buffer invalid memory access

When the number of triangles in a node became zero, the wireframe batch was
not freed along with the triangles batch and could still reference a freed
vertex buffer.

Ref T76858

Fix T76813: Snap to Edge Center returning a different normal from snap to Edge

This difference was intentional, but using the edge direction as normal is more useful.

Refactor: Move workspace foreach_id to new IDTypeInfo structure.

Refactor: Move WindowManager and Screen foreach_id to new IDTypeInfo structure.

That one was a bit more complicated, and is still only partial refactor
(ultimately we want to have a foreach_id callback in SpaceType itself I
think...).

Refactor: Move action foreach_id to new IDTypeInfo structure.

Merge branch 'blender-v2.83-release'

Outliner: Fix (unreported) more data-changing operators missing undo.

Merge branch 'blender-v2.83-release'

Fix part of T76544: dyntopo sculpt undo stack memory leak

OIpenSubdiv: Cleanup, move to a better sounding namespace

The code is not only part of C-API, but also implements Blender-specific
glue level implementation.

Fix T76814: [Mantaflow] Surface Tension always works

Initialize the curvature grid and compute the laplacian only if the diffusion flag is set.

Fix T76795: Missing node tree update after remove-on-cancel

Reviewers: brecht

Differential Revision: https://developer.blender.org/D7775