Blender Git Commit Log

Tracking: Clarify tracks and options storage once again

This is something not-so-trivial to see from just reading code, which
shown an important of proper comments and clear naming.

Main source of confusion was that it is not immediately clear that
AutoTrack context is to see all tracks, but tracking to only operate on
selected ones.

Geometry Nodes: Change modifier name

The modifier was called "Empty", which reflects the fact that the modifier
doesn't do anything when you add it. However, that is not true after you
change the modifier's node group, and the fact that the modifier uses
nodes is the one thing that distinguishes it at this point. This commit
changes the name to "Geometry Nodes", which is simple and consistent
with the "Geometry Node Editor" and the naming of the project so far.

Windows/Ninja: allow parameters for rebuild.cmd

The windows build leaves a convenience helper script
in the build folder called, rebuild.cmd. This change
passes any parameters you give rebuild.cmd to ninja
so you can easily pass it additional parameters without
having to edit the batch file manually.

GPencil: New operator to reset Vertex Colors

This operators reset the vertex color information of the strokes.

If nothing is selected, all strokes are reset. If any is selected, only selected strokes are reset.

Also added a new menu Paint in Vertex Color mode.

Differential Revision: https://developer.blender.org/D9647

Tracking: Cleanup, remove unused argument from image accessor

Tracking: Cleanup, remove unused field

Was re-introduced after previous round of cleanups when was merging
refactor and master branches.

Remove preview pointer in asset-data

Not needed, we get the preview via the ID.

Importer: remove useless `{}`s. renames.

Tracking: Cleanup, use explicit frame match option

No functional changes, just allows to potentially extend the options
in the future, and also makes code more explicit.

Exporter: remove useless `{}`s.

Tracking: Cleanup pattern match DNA definition

Wrong comment was used for enumerator.

Also made it a real typed enumerator to ease use in the implementation
code.

Should be no functional changes.

Fix T83203 BGL: shader.program wrongly always returns 0

This was a leftover from the 2.91 GPU module refactor.

This is an exception that should be removed when we remove BGL.

Tracking: Cleanup, finish pass of comments in the context

Some fields are still not really documented, but they are subject of
refactor/fix which will happen shortly.

Tracking: Cleanup, replace clip user with frame number

Makes it more clear from intent and usage point of view.
The user was not used for anything else than frame number.

Tracking: Cleanup, more clear variable naming

A no-functional-followup of the previous commit.

Tracking: Fix missing frame remap for plane tracks

Tracking track which is used for plane track and movie clip having
a scene frame offset would have trigger re-calculation from a wrong
frame.

Tracking: Cleanup, clear variable names and indentation

Should be no functional changes.

Tracking: Cleanup, unused field in autotrack context

Was only assigned to truth, always. Never read back.

Cleanup: Use C++ scope based mutex locks

Rather than verbose and unsafe (in case of early exits or exceptions) explicit
lock/unlock pairs, use RAII based locks which explicitly unlock on stack
unwinding.

Compile BKE icons source file with C++

That way we can use scoped mutex locks, which should make code cleaner/saver
and avoids the annoying unlock calls for every early-exit. Will happen in a
followup commit.

Mostly had to address casts from `void *` of course. Used C style casts, almost
all of the file still uses C style coding anyway.
`BKE_icon_geom_from_memory()` was using `goto`s for cleanup logic which
wouldn't compile with C++. Changed to RAII based resource handling.